third_codes/PowerJob
1
0
Fork 1
mirror of https://github.com/PowerJob/PowerJob.git synced 2025-07-17 00:00:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

[fix] fix the NPE of OmsCenterAlarmService

Browse Source
This commit is contained in:
tjq 2020-05-18 12:34:31 +08:00
parent a2336354d9
commit 150b1fd919
1 changed files with 29 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
oh-my-scheduler-server/src/main/java/com/github/kfcfans/oms/server/service/alarm/OmsCenterAlarmService.java
View File

@ -12,6 +12,7 @@ import org.springframework.scheduling.annotation.Async;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
import java.util.List; import java.util.List;
import java.util.concurrent.atomic.AtomicBoolean;
/** /**
* 报警服务 * 报警服务
@ -21,13 +22,14 @@ import java.util.List;
*/ */
@Slf4j @Slf4j
@Service("omsCenterAlarmService") @Service("omsCenterAlarmService")
public class OmsCenterAlarmService implements Alarmable, InitializingBean { public class OmsCenterAlarmService implements Alarmable {
@Setter @Setter
@Value("${oms.alarm.bean.names}") @Value("${oms.alarm.bean.names}")
private String beanNames; private String beanNames;
private List<Alarmable> alarmableList; private List<Alarmable> alarmableList;
private volatile boolean initialized = false;
public OmsCenterAlarmService() { public OmsCenterAlarmService() {
} }
@ -35,6 +37,7 @@ public class OmsCenterAlarmService implements Alarmable, InitializingBean {
@Async("omsCommonPool") @Async("omsCommonPool")
@Override @Override
public void alarm(AlarmContent alarmContent, List<UserInfoDO> targetUserList) { public void alarm(AlarmContent alarmContent, List<UserInfoDO> targetUserList) {
init();
alarmableList.forEach(alarmable -> { alarmableList.forEach(alarmable -> {
try { try {
alarmable.alarm(alarmContent, targetUserList); alarmable.alarm(alarmContent, targetUserList);
@ -44,18 +47,32 @@ public class OmsCenterAlarmService implements Alarmable, InitializingBean {
}); });
} }
/**
* 初始化
* 使用 InitializingBean 进行初始化会导致 NPE，因为没办法控制Bean（开发者自己实现的Bean）的加载顺序
*/
private void init() {
@Override if (initialized) {
public void afterPropertiesSet() throws Exception { return;
alarmableList = Lists.newLinkedList(); }
Splitter.on(",").split(beanNames).forEach(beanName -> { synchronized (this) {
try { if (initialized) {
Alarmable bean = (Alarmable) SpringUtils.getBean(beanName); return;
alarmableList.add(bean);
log.info("[OmsCenterAlarmService] load Alarmable for bean: {} successfully.", beanName);
}catch (Exception e) {
log.warn("[OmsCenterAlarmService] initialize Alarmable for bean: {} failed.", beanName, e);
} }
});
alarmableList = Lists.newLinkedList();
Splitter.on(",").split(beanNames).forEach(beanName -> {
try {
Alarmable bean = (Alarmable) SpringUtils.getBean(beanName);
alarmableList.add(bean);
log.info("[OmsCenterAlarmService] load Alarmable for bean: {} successfully.", beanName);
}catch (Exception e) {
log.warn("[OmsCenterAlarmService] initialize Alarmable for bean: {} failed.", beanName, e);
}
});
initialized = true;
}
} }
} }