From 4c0e5f348b669c029ea8fb668dbd298100e8e54f Mon Sep 17 00:00:00 2001
From: tjq <tengjiqi@gmail.com>
Date: Wed, 3 Nov 2021 21:26:25 +0800
Subject: [PATCH] fix: can creating a job with the wrong parameters #312

---
 .../java/tech/powerjob/common/utils/CommonUtils.java |  7 +++++++
 .../powerjob/server/core/service/JobService.java     | 12 +++++++++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/powerjob-common/src/main/java/tech/powerjob/common/utils/CommonUtils.java b/powerjob-common/src/main/java/tech/powerjob/common/utils/CommonUtils.java
index 498d5b73..df23ce8c 100644
--- a/powerjob-common/src/main/java/tech/powerjob/common/utils/CommonUtils.java
+++ b/powerjob-common/src/main/java/tech/powerjob/common/utils/CommonUtils.java
@@ -173,4 +173,11 @@ public class CommonUtils {
         } catch (InterruptedException ignore) {
         }
     }
+
+    /**
+     * ignore compile warning of 'Result of 'Long.valueOf()' is ignored '
+     * @param obj anything
+     */
+    public static void ignoreIgnoredResultWarning(Object obj) {
+    }
 }
diff --git a/powerjob-server/powerjob-server-core/src/main/java/tech/powerjob/server/core/service/JobService.java b/powerjob-server/powerjob-server-core/src/main/java/tech/powerjob/server/core/service/JobService.java
index 9c198373..cb194055 100644
--- a/powerjob-server/powerjob-server-core/src/main/java/tech/powerjob/server/core/service/JobService.java
+++ b/powerjob-server/powerjob-server-core/src/main/java/tech/powerjob/server/core/service/JobService.java
@@ -6,6 +6,7 @@ import tech.powerjob.common.PowerQuery;
 import tech.powerjob.common.enums.TimeExpressionType;
 import tech.powerjob.common.request.http.SaveJobInfoRequest;
 import tech.powerjob.common.response.JobInfoDTO;
+import tech.powerjob.common.utils.CommonUtils;
 import tech.powerjob.server.common.SJ;
 import tech.powerjob.server.common.constants.SwitchableStatus;
 import tech.powerjob.server.common.utils.CronExpression;
@@ -61,7 +62,7 @@ public class JobService {
      */
     public Long saveJob(SaveJobInfoRequest request) throws ParseException {
 
-        request.valid();
+        checkValid(request);
 
         JobInfoDO jobInfoDO;
         if (request.getId() != null) {
@@ -278,4 +279,13 @@ public class JobService {
         return jobInfoDTO;
     }
 
+    private static void checkValid(SaveJobInfoRequest request) {
+
+        request.valid();
+
+        if (TimeExpressionType.frequentTypes.contains(request.getTimeExpressionType().getV())) {
+            CommonUtils.ignoreIgnoredResultWarning(Long.valueOf(request.getTimeExpression()));
+        }
+    }
+
 }