From 540849524d40dfb128b1b88b60c8093396cddf83 Mon Sep 17 00:00:00 2001
From: Echo009 <ech0.extreme@foxmail.com>
Date: Wed, 24 Feb 2021 16:34:09 +0800
Subject: [PATCH] fix: NPE when fetch workflow info

---
 .../powerjob/server/service/workflow/WorkflowService.java  | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/powerjob-server/src/main/java/com/github/kfcfans/powerjob/server/service/workflow/WorkflowService.java b/powerjob-server/src/main/java/com/github/kfcfans/powerjob/server/service/workflow/WorkflowService.java
index d1e4d076..4e650b9c 100644
--- a/powerjob-server/src/main/java/com/github/kfcfans/powerjob/server/service/workflow/WorkflowService.java
+++ b/powerjob-server/src/main/java/com/github/kfcfans/powerjob/server/service/workflow/WorkflowService.java
@@ -266,13 +266,14 @@ public class WorkflowService {
 
         WorkflowInfoVO res =  WorkflowInfoVO.from(wfInfo);
 
-        PEWorkflowDAG dagInfo;
+        PEWorkflowDAG dagInfo = null;
         try {
             dagInfo = JSON.parseObject(wfInfo.getPeDAG(), PEWorkflowDAG.class);
         } catch (Exception e) {
             log.warn("[WorkflowService-{}]illegal DAG : {}", wfInfo.getId(), wfInfo.getPeDAG());
-            // 这里直接返回空对象
-            res.setPEWorkflowDAG(new PEWorkflowDAG());
+        }
+        if (dagInfo == null) {
+            // 这里直接返回
             return res;
         }