* fix: bug #324

Fail to cancel delay job instance by id via API

* style: correct log

* style: update log

Co-authored-by: Echo009 <ech0.extreme@foxmail.com>
This commit is contained in:
Justin Zhang 2022-08-31 23:12:10 +08:00 committed by GitHub
parent e094c22952
commit 75c88c32ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions

View File

@ -191,8 +191,8 @@ public class InstanceService {
* @param instanceId 任务实例
*/
@DesignateServer
public void cancelInstance(Long instanceId) {
log.info("[Instance-{}] try to cancel the instance.", instanceId);
public void cancelInstance(Long appId, Long instanceId) {
log.info("[Instance-{}] try to cancel the instance with appId {}.", instanceId, appId);
try {
InstanceInfoDO instanceInfo = fetchInstanceInfo(instanceId);

View File

@ -126,7 +126,7 @@ public class OpenAPIController {
@PostMapping(OpenAPIConstant.CANCEL_INSTANCE)
public ResultDTO<Void> cancelInstance(Long instanceId, Long appId) {
checkInstanceIdValid(instanceId, appId);
instanceService.cancelInstance(instanceId);
instanceService.cancelInstance(appId, instanceId);
return ResultDTO.success(null);
}