From 5831e824e14b61f5be8f2e0693b6442b1795a00d Mon Sep 17 00:00:00 2001 From: Andreas Gudian Date: Fri, 18 Dec 2015 22:47:03 +0100 Subject: [PATCH] Organize imports to put static imports back on top. --- .../testutil/runner/ProcessorSuiteRunner.java | 8 ++++---- .../AbstractJodaTypeToStringConversion.java | 4 ++-- .../BigDecimalToBigIntegerConversion.java | 4 ++-- .../BigDecimalToPrimitiveConversion.java | 4 ++-- .../BigDecimalToStringConversion.java | 4 ++-- .../BigDecimalToWrapperConversion.java | 4 ++-- .../BigIntegerToPrimitiveConversion.java | 4 ++-- .../BigIntegerToStringConversion.java | 4 ++-- .../BigIntegerToWrapperConversion.java | 4 ++-- .../ap/internal/conversion/Conversions.java | 4 ++-- .../conversion/DateToStringConversion.java | 6 +++--- .../conversion/EnumStringConversion.java | 4 ++-- .../JodaDateTimeToCalendarConversion.java | 4 ++-- .../conversion/JodaTimeToDateConversion.java | 4 ++-- .../ap/internal/model/Decorator.java | 15 ++++++++------- .../mapstruct/ap/internal/model/Direct.java | 8 ++++---- .../ap/internal/model/EnumMappingMethod.java | 4 ++-- .../ap/internal/model/MappingMethod.java | 6 +++--- .../ap/internal/model/PropertyMapping.java | 12 ++++++------ .../ap/internal/model/ServicesEntry.java | 6 +++--- .../ap/internal/model/TypeConversion.java | 8 ++++---- .../model/assignment/ArrayCopyWrapper.java | 6 +++--- .../internal/model/common/Accessibility.java | 1 + .../common/DateFormatValidatorFactory.java | 8 ++++---- .../ap/internal/model/common/TypeFactory.java | 4 ++-- .../internal/model/source/MethodMatcher.java | 4 ++-- .../CalendarToXmlGregorianCalendar.java | 4 ++-- .../builtin/DateToXmlGregorianCalendar.java | 4 ++-- .../model/source/builtin/JaxbElemToValue.java | 4 ++-- .../builtin/StringToXmlGregorianCalendar.java | 4 ++-- .../XmlGregorianCalendarToCalendar.java | 4 ++-- .../builtin/XmlGregorianCalendarToDate.java | 4 ++-- .../builtin/XmlGregorianCalendarToString.java | 4 ++-- .../source/selector/InheritanceSelector.java | 4 ++-- .../source/selector/SelectionCriteria.java | 1 + .../naming/DefaultAccessorNamingStrategy.java | 1 + .../ap/internal/prism/PrismGenerator.java | 6 +++--- .../processor/MethodRetrievalProcessor.java | 5 +++-- .../ap/internal/util/MapperConfiguration.java | 19 ++++++++++--------- .../mapstruct/ap/internal/util/Strings.java | 4 ++-- .../writer/FreeMarkerModelElementWriter.java | 4 ++-- .../writer/ModelIncludeDirective.java | 4 ++-- .../DateFormatValidatorFactoryTest.java | 16 ++++++++-------- .../common/DefaultConversionContextTest.java | 18 +++++++++--------- .../test/abstractclass/AbstractClassTest.java | 4 ++-- .../generics/GenericsHierarchyTest.java | 4 ++-- .../ap/test/array/ArrayMappingTest.java | 4 ++-- .../ap/test/bool/BooleanMappingTest.java | 4 ++-- .../ap/test/bugs/_289/Issue289Test.java | 1 + .../ap/test/bugs/_374/Issue374Mapper.java | 1 + .../ap/test/bugs/_374/Issue374Test.java | 4 +++- .../ap/test/bugs/_374/Issue374VoidMapper.java | 1 + .../SameClassNameInDifferentPackageTest.java | 10 +++++----- .../SameNameForSourceAndTargetCarsMapper.java | 7 +++---- .../ap/test/bugs/_405/PersonMapper.java | 1 + .../ap/test/bugs/_513/Issue513Test.java | 1 + .../ap/test/bugs/_516/Issue516Test.java | 1 + .../ap/test/bugs/_580/Issue580Test.java | 4 ++-- .../ap/test/bugs/_581/SourceTargetMapper.java | 4 ++-- .../ap/test/bugs/_625/Issue625Test.java | 4 ++-- .../ap/test/bugs/_631/Issue631Test.java | 1 + .../ap/test/builtin/BuiltInTest.java | 5 ++--- .../builtin/bean/JaxbElementListProperty.java | 3 ++- .../mapper/IterableSourceTargetMapper.java | 5 ++--- .../builtin/mapper/MapSourceTargetMapper.java | 5 ++--- .../mapper/SourceTargetWithDateMapper.java | 2 +- .../ap/test/callbacks/CallbackMethodTest.java | 4 ++-- .../MappingResultPostprocessorTest.java | 6 +++--- .../CallbackMethodTypeMatchingTest.java | 4 ++-- .../ap/test/collection/adder/AdderTest.java | 14 ++++++-------- .../ap/test/collection/adder/PetMapper.java | 4 ++-- .../NoSetterCollectionMappingTest.java | 7 +++---- .../EmptyItererableMappingMapper.java | 1 + .../erroneous/EmptyMapMappingMapper.java | 1 + .../ErroneousCollectionMappingTest.java | 10 +++++----- ...oneousCollectionNoElementMappingFound.java | 1 + .../ErroneousCollectionNoKeyMappingFound.java | 1 + ...rroneousCollectionNoValueMappingFound.java | 1 + .../forged/CollectionMappingTest.java | 4 ++-- .../test/collection/map/MapMappingTest.java | 7 +++---- .../collection/map/SourceTargetMapper.java | 2 +- .../test/collection/wildcard/BeanMapper.java | 2 ++ .../test/collection/wildcard/CunningPlan.java | 1 + ...neousIterableExtendsBoundTargetMapper.java | 1 + ...roneousIterableSuperBoundSourceMapper.java | 1 + ...ousIterableTypeVarBoundMapperOnMapper.java | 1 + ...ousIterableTypeVarBoundMapperOnMethod.java | 1 + .../ap/test/collection/wildcard/GoodIdea.java | 1 + .../collection/wildcard/WildCardTest.java | 12 ++++++------ .../mapstruct/ap/test/complex/CarMapper.java | 2 +- .../test/conversion/SourceTargetMapper.java | 2 +- .../java8time/Java8TimeConversionTest.java | 4 ++-- .../jodatime/JodaConversionTest.java | 4 ++-- .../nativetypes/BooleanConversionTest.java | 4 ++-- .../nativetypes/CharConversionTest.java | 4 ++-- .../nativetypes/NumberConversionTest.java | 4 ++-- .../string/StringConversionTest.java | 4 ++-- .../decorator/jsr330/Jsr330DecoratorTest.java | 4 ++-- .../decorator/spring/SpringDecoratorTest.java | 4 ++-- .../test/defaultvalue/DefaultValueTest.java | 4 ++-- .../ap/test/dependency/OrderingTest.java | 4 ++-- .../destination/DestinationClassNameTest.java | 4 ++-- .../DestinationPackageNameTest.java | 4 ++-- .../ap/test/exceptions/ExceptionTest.java | 5 +++-- .../test/exceptions/SourceTargetMapper.java | 3 ++- .../ap/test/generics/GenericsTest.java | 4 ++-- .../imports/ConflictingTypesNamesTest.java | 4 ++-- .../InheritedMappingMethodTest.java | 4 ++-- .../NestedMappingMethodInvocationTest.java | 2 +- .../NestedSourcePropertiesTest.java | 12 +++++------- .../nonvoidsetter/NonVoidSettersTest.java | 4 ++-- .../ap/test/nullcheck/NullCheckTest.java | 1 + .../ap/test/nullvaluemapping/CarMapper.java | 6 +++--- .../CarMapperSettingOnMapper.java | 2 +- .../NullValueMappingTest.java | 4 ++-- .../ap/test/prism/EnumPrismsTest.java | 4 ++-- .../test/references/ReferencedMapperTest.java | 7 +++---- .../test/references/statics/StaticsTest.java | 9 +++++---- .../InheritInverseConfigurationTest.java | 4 ++-- .../PrimitiveVsWrappedSelectionTest.java | 1 + .../test/selection/qualifier/FactMapper.java | 1 + .../selection/qualifier/KeyWordMapper.java | 4 +++- .../selection/qualifier/QualifierTest.java | 15 +++++++++------ .../annotation/CreateGermanRelease.java | 1 + .../qualifier/annotation/EnglishToGerman.java | 1 + .../qualifier/annotation/TitleTranslator.java | 1 + .../qualifier/handwritten/Facts.java | 4 +++- .../qualifier/handwritten/PlotWords.java | 4 +++- .../qualifier/handwritten/Titles.java | 4 +++- .../resulttype/FruitFamilyMapper.java | 1 + .../resulttype/InheritanceSelectionTest.java | 4 ++-- .../SeveralSourceParametersTest.java | 4 ++-- .../source/constants/SourceConstantsTest.java | 4 ++-- .../expressions/java/SourceTargetMapper.java | 2 +- .../template/InheritConfigurationTest.java | 4 ++-- .../test/updatemethods/UpdateMethodsTest.java | 4 ++-- .../selection/ExternalHandWrittenMapper.java | 1 + .../selection/ExternalSelectionTest.java | 4 ++-- .../testutil/runner/CompilingStatement.java | 4 ++-- 139 files changed, 326 insertions(+), 286 deletions(-) diff --git a/integrationtest/src/test/java/org/mapstruct/itest/testutil/runner/ProcessorSuiteRunner.java b/integrationtest/src/test/java/org/mapstruct/itest/testutil/runner/ProcessorSuiteRunner.java index 6ee3d8e97..2f44fdc12 100644 --- a/integrationtest/src/test/java/org/mapstruct/itest/testutil/runner/ProcessorSuiteRunner.java +++ b/integrationtest/src/test/java/org/mapstruct/itest/testutil/runner/ProcessorSuiteRunner.java @@ -18,6 +18,10 @@ */ package org.mapstruct.itest.testutil.runner; +import static org.apache.maven.it.util.ResourceExtractor.extractResourceToDestination; +import static org.apache.maven.shared.utils.io.FileUtils.copyURLToFile; +import static org.apache.maven.shared.utils.io.FileUtils.deleteDirectory; + import java.io.File; import java.io.IOException; import java.io.PrintStream; @@ -46,10 +50,6 @@ import org.mapstruct.itest.testutil.runner.ProcessorSuiteRunner.ProcessorTestCas import org.mapstruct.itest.testutil.runner.xml.Toolchains; import org.mapstruct.itest.testutil.runner.xml.Toolchains.ProviderDescription; -import static org.apache.maven.it.util.ResourceExtractor.extractResourceToDestination; -import static org.apache.maven.shared.utils.io.FileUtils.copyURLToFile; -import static org.apache.maven.shared.utils.io.FileUtils.deleteDirectory; - /** * Runner for processor integration tests. Requires the annotation {@link ProcessorSuite} on the test class. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/AbstractJodaTypeToStringConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/AbstractJodaTypeToStringConversion.java index 70942463e..d5b60aee2 100755 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/AbstractJodaTypeToStringConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/AbstractJodaTypeToStringConversion.java @@ -18,6 +18,8 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.util.Collections; import java.util.Locale; import java.util.Set; @@ -26,8 +28,6 @@ import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; import org.mapstruct.ap.internal.util.JodaTimeConstants; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Base class for conversions between Joda-Time types and String. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToBigIntegerConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToBigIntegerConversion.java index d6f8ed660..0e29355b4 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToBigIntegerConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToBigIntegerConversion.java @@ -18,6 +18,8 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.math.BigDecimal; import java.math.BigInteger; import java.util.Set; @@ -25,8 +27,6 @@ import java.util.Set; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link BigDecimal} and {@link BigInteger}. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToPrimitiveConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToPrimitiveConversion.java index 67db380da..326ea198b 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToPrimitiveConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToPrimitiveConversion.java @@ -18,14 +18,14 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.math.BigDecimal; import java.util.Set; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link BigDecimal} and native number types. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToStringConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToStringConversion.java index 9828eb4b0..8e72600bf 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToStringConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToStringConversion.java @@ -18,14 +18,14 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.math.BigDecimal; import java.util.Set; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link BigDecimal} and {@link String}. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToWrapperConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToWrapperConversion.java index 6982ac65a..064bd5db1 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToWrapperConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigDecimalToWrapperConversion.java @@ -18,6 +18,8 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.math.BigDecimal; import java.util.Set; @@ -25,8 +27,6 @@ import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; import org.mapstruct.ap.internal.util.NativeTypes; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link BigDecimal} and wrappers of native number types. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToPrimitiveConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToPrimitiveConversion.java index 69e80e8f3..0d141aed4 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToPrimitiveConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToPrimitiveConversion.java @@ -18,14 +18,14 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.math.BigInteger; import java.util.Set; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link BigInteger} and native number types. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToStringConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToStringConversion.java index 156354603..2f22affcd 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToStringConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToStringConversion.java @@ -18,14 +18,14 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.math.BigInteger; import java.util.Set; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link BigInteger} and {@link String}. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToWrapperConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToWrapperConversion.java index 9ba2e39b9..90061e782 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToWrapperConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/BigIntegerToWrapperConversion.java @@ -18,6 +18,8 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.math.BigInteger; import java.util.Set; @@ -25,8 +27,6 @@ import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; import org.mapstruct.ap.internal.util.NativeTypes; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link BigInteger} and wrappers of native number types. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/Conversions.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/Conversions.java index 662c4bab3..7e77d5944 100755 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/Conversions.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/Conversions.java @@ -18,6 +18,8 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.conversion.ReverseConversion.reverse; + import java.math.BigDecimal; import java.math.BigInteger; import java.util.Calendar; @@ -32,8 +34,6 @@ import org.mapstruct.ap.internal.model.common.TypeFactory; import org.mapstruct.ap.internal.util.JavaTimeConstants; import org.mapstruct.ap.internal.util.JodaTimeConstants; -import static org.mapstruct.ap.internal.conversion.ReverseConversion.reverse; - /** * Holds built-in {@link ConversionProvider}s such as from {@code int} to {@code String}. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/DateToStringConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/DateToStringConversion.java index 8cba76baa..cfacb7904 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/DateToStringConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/DateToStringConversion.java @@ -18,6 +18,9 @@ */ package org.mapstruct.ap.internal.conversion; +import static java.util.Arrays.asList; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.text.ParseException; import java.text.SimpleDateFormat; import java.util.Collections; @@ -28,9 +31,6 @@ import org.mapstruct.ap.internal.model.assignment.Assignment; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static java.util.Arrays.asList; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link String} and {@link Date}. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/EnumStringConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/EnumStringConversion.java index 215e7c466..4a89372a5 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/EnumStringConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/EnumStringConversion.java @@ -18,13 +18,13 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.util.Set; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@link String} and {@link Enum} types. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/JodaDateTimeToCalendarConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/JodaDateTimeToCalendarConversion.java index ff37151ba..417ad55c9 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/JodaDateTimeToCalendarConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/JodaDateTimeToCalendarConversion.java @@ -18,6 +18,8 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.util.Calendar; import java.util.Locale; import java.util.Set; @@ -25,8 +27,6 @@ import java.util.Set; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between {@code DateTime} and {@link Calendar}. * diff --git a/processor/src/main/java/org/mapstruct/ap/internal/conversion/JodaTimeToDateConversion.java b/processor/src/main/java/org/mapstruct/ap/internal/conversion/JodaTimeToDateConversion.java index 8164ce71a..ab92b7fdc 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/conversion/JodaTimeToDateConversion.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/conversion/JodaTimeToDateConversion.java @@ -18,14 +18,14 @@ */ package org.mapstruct.ap.internal.conversion; +import static org.mapstruct.ap.internal.util.Collections.asSet; + import java.util.Date; import java.util.Set; import org.mapstruct.ap.internal.model.common.ConversionContext; import org.mapstruct.ap.internal.model.common.Type; -import static org.mapstruct.ap.internal.util.Collections.asSet; - /** * Conversion between the following Joda types and {@link Date}: *