mirror of
https://github.com/mapstruct/mapstruct.git
synced 2025-07-12 00:00:08 +08:00
#846 Exclude updates methods from suitable constructor check
This commit is contained in:
parent
1b6b5f18bb
commit
75021ada1b
@ -460,8 +460,9 @@ public class MapperCreationProcessor implements ModelElementProcessor<List<Sourc
|
||||
|
||||
// is there a suitable constructor
|
||||
if ( method.isBeanMapping()
|
||||
&& !method.getResultType().isCollectionOrMapType()
|
||||
&& !method.getResultType().hasEmptyAccessibleContructor() ) {
|
||||
&& !method.isUpdateMethod()
|
||||
&& !method.getReturnType().isCollectionOrMapType()
|
||||
&& !method.getReturnType().hasEmptyAccessibleContructor() ) {
|
||||
reportErrorWhenNoSuitableConstrutor( method, reversePrism );
|
||||
return null;
|
||||
}
|
||||
|
@ -0,0 +1,78 @@
|
||||
/**
|
||||
* Copyright 2012-2016 Gunnar Morling (http://www.gunnarmorling.de/)
|
||||
* and/or other contributors as indicated by the @authors tag. See the
|
||||
* copyright.txt file in the distribution for a full listing of all
|
||||
* contributors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
package org.mapstruct.ap.test.bugs._846;
|
||||
|
||||
import org.mapstruct.InheritInverseConfiguration;
|
||||
import org.mapstruct.Mapper;
|
||||
import org.mapstruct.Mapping;
|
||||
import org.mapstruct.MappingTarget;
|
||||
|
||||
public class Mapper846 {
|
||||
|
||||
interface BInterface {
|
||||
|
||||
String getName();
|
||||
|
||||
void setName(String s);
|
||||
}
|
||||
|
||||
static class B implements BInterface {
|
||||
|
||||
String name;
|
||||
|
||||
B() {
|
||||
}
|
||||
|
||||
@Override
|
||||
public String getName() {
|
||||
return name;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void setName(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
}
|
||||
|
||||
static class A {
|
||||
|
||||
String aName;
|
||||
|
||||
A() {
|
||||
}
|
||||
|
||||
public String getaName() {
|
||||
return aName;
|
||||
}
|
||||
|
||||
public void setaName(String name) {
|
||||
this.aName = name;
|
||||
}
|
||||
}
|
||||
|
||||
@Mapper
|
||||
interface MyMapper {
|
||||
|
||||
@Mapping(source = "name", target = "aName")
|
||||
A convert(BInterface b);
|
||||
|
||||
@InheritInverseConfiguration
|
||||
void convert(@MappingTarget BInterface target, A source);
|
||||
}
|
||||
}
|
@ -0,0 +1,39 @@
|
||||
/**
|
||||
* Copyright 2012-2016 Gunnar Morling (http://www.gunnarmorling.de/)
|
||||
* and/or other contributors as indicated by the @authors tag. See the
|
||||
* copyright.txt file in the distribution for a full listing of all
|
||||
* contributors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
package org.mapstruct.ap.test.bugs._846;
|
||||
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mapstruct.ap.testutil.IssueKey;
|
||||
import org.mapstruct.ap.testutil.WithClasses;
|
||||
import org.mapstruct.ap.testutil.runner.AnnotationProcessorTestRunner;
|
||||
|
||||
@RunWith(AnnotationProcessorTestRunner.class)
|
||||
@IssueKey("846")
|
||||
@WithClasses({
|
||||
Mapper846.class
|
||||
})
|
||||
public class UpdateTest {
|
||||
|
||||
@Test
|
||||
public void shouldProduceMapper() {
|
||||
|
||||
}
|
||||
|
||||
}
|
Loading…
x
Reference in New Issue
Block a user