third_codes/mapstruct
1
0
Fork 0
mirror of https://github.com/mapstruct/mapstruct.git synced 2025-07-12 00:00:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

#35 Unifying messsage printing

Browse Source
This commit is contained in:
Gunnar Morling 2013-06-09 21:49:25 +02:00
parent bf5a4303b6
commit 76c3aebd5d
1 changed files with 37 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
processor/src/main/java/org/mapstruct/ap/MapperGenerationVisitor.java
View File

@ -41,7 +41,6 @@ import javax.lang.model.type.TypeMirror;
import javax.lang.model.util.ElementKindVisitor6; import javax.lang.model.util.ElementKindVisitor6;
import javax.lang.model.util.Elements; import javax.lang.model.util.Elements;
import javax.lang.model.util.Types; import javax.lang.model.util.Types;
import javax.tools.Diagnostic.Kind;
import javax.tools.JavaFileObject; import javax.tools.JavaFileObject;
import org.mapstruct.ap.conversion.Conversion; import org.mapstruct.ap.conversion.Conversion;
@ -327,7 +326,8 @@ public class MapperGenerationVisitor extends ElementKindVisitor6<Void, Void> {
( property.getTargetType().isCollectionType() && property.getTargetType() ( property.getTargetType().isCollectionType() && property.getTargetType()
.getCollectionImplementationType() != null ) ) ) { .getCollectionImplementationType() != null ) ) ) {
reportError( printMessage(
ReportingPolicy.ERROR,
String.format( String.format(
"Can't map property \"%s %s\" to \"%s %s\".", "Can't map property \"%s %s\" to \"%s %s\".",
property.getSourceType(), property.getSourceType(),
@ -349,7 +349,8 @@ public class MapperGenerationVisitor extends ElementKindVisitor6<Void, Void> {
( property.getSourceType().isCollectionType() && property.getSourceType() ( property.getSourceType().isCollectionType() && property.getSourceType()
.getCollectionImplementationType() != null ) ) ) { .getCollectionImplementationType() != null ) ) ) {
reportError( printMessage(
ReportingPolicy.ERROR,
String.format( String.format(
"Can't map property \"%s %s\" to \"%s %s\".", "Can't map property \"%s %s\" to \"%s %s\".",
property.getTargetType(), property.getTargetType(),
@ -457,19 +458,35 @@ public class MapperGenerationVisitor extends ElementKindVisitor6<Void, Void> {
if ( implementationRequired ) { if ( implementationRequired ) {
if ( parameter.getType().isIterableType() && !returnType.isIterableType() ) { if ( parameter.getType().isIterableType() && !returnType.isIterableType() ) {
reportError( "Can't generate mapping method from iterable type to non-iterable type.", method ); printMessage(
ReportingPolicy.ERROR,
"Can't generate mapping method from iterable type to non-iterable type.",
method
);
mappingErroneous = true; mappingErroneous = true;
} }
if ( !parameter.getType().isIterableType() && returnType.isIterableType() ) { if ( !parameter.getType().isIterableType() && returnType.isIterableType() ) {
reportError( "Can't generate mapping method from non-iterable type to iterable type.", method ); printMessage(
ReportingPolicy.ERROR,
"Can't generate mapping method from non-iterable type to iterable type.",
method
);
mappingErroneous = true; mappingErroneous = true;
} }
if ( parameter.getType().isPrimitive() ) { if ( parameter.getType().isPrimitive() ) {
reportError( "Can't generate mapping method with primitive parameter type.", method ); printMessage(
ReportingPolicy.ERROR,
"Can't generate mapping method with primitive parameter type.",
method
);
mappingErroneous = true; mappingErroneous = true;
} }
if ( returnType.isPrimitive() ) { if ( returnType.isPrimitive() ) {
reportError( "Can't generate mapping method with primitive return type.", method ); printMessage(
ReportingPolicy.ERROR,
"Can't generate mapping method with primitive return type.",
method
);
mappingErroneous = true; mappingErroneous = true;
} }
@ -605,7 +622,8 @@ public class MapperGenerationVisitor extends ElementKindVisitor6<Void, Void> {
for ( Mapping mappedProperty : mappings.values() ) { for ( Mapping mappedProperty : mappings.values() ) {
if ( !sourcePropertyNames.contains( mappedProperty.getSourceName() ) ) { if ( !sourcePropertyNames.contains( mappedProperty.getSourceName() ) ) {
reportError( printMessage(
ReportingPolicy.ERROR,
String.format( String.format(
"Unknown property \"%s\" in parameter type %s.", "Unknown property \"%s\" in parameter type %s.",
mappedProperty.getSourceName(), mappedProperty.getSourceName(),
@ -614,7 +632,8 @@ public class MapperGenerationVisitor extends ElementKindVisitor6<Void, Void> {
); );
} }
if ( !targetPropertyNames.contains( mappedProperty.getTargetName() ) ) { if ( !targetPropertyNames.contains( mappedProperty.getTargetName() ) ) {
reportError( printMessage(
ReportingPolicy.ERROR,
String.format( String.format(
"Unknown property \"%s\" in return type %s.", "Unknown property \"%s\" in return type %s.",
mappedProperty.getTargetName(), mappedProperty.getTargetName(),
@ -670,22 +689,19 @@ public class MapperGenerationVisitor extends ElementKindVisitor6<Void, Void> {
return typeUtil.retrieveType( method.getReturnType() ); return typeUtil.retrieveType( method.getReturnType() );
} }
private void reportError(String message, Element element) {
processingEnvironment.getMessager().printMessage( Kind.ERROR, message, element );
mappingErroneous = true;
}
private void reportError(String message, Element element, AnnotationMirror annotationMirror,
AnnotationValue annotationValue) {
processingEnvironment.getMessager()
.printMessage( Kind.ERROR, message, element, annotationMirror, annotationValue );
mappingErroneous = true;
}
private void printMessage(ReportingPolicy reportingPolicy, String message, Element element) { private void printMessage(ReportingPolicy reportingPolicy, String message, Element element) {
processingEnvironment.getMessager().printMessage( reportingPolicy.getDiagnosticKind(), message, element ); processingEnvironment.getMessager().printMessage( reportingPolicy.getDiagnosticKind(), message, element );
if ( reportingPolicy.failsBuild() ) { if ( reportingPolicy.failsBuild() ) {
mappingErroneous = true; mappingErroneous = true;
} }
} }
private void printMessage(ReportingPolicy reportingPolicy, String message, Element element,
AnnotationMirror annotationMirror, AnnotationValue annotationValue) {
processingEnvironment.getMessager()
.printMessage( reportingPolicy.getDiagnosticKind(), message, element, annotationMirror, annotationValue );
if ( reportingPolicy.failsBuild() ) {
mappingErroneous = true;
}
}
} }