third_codes/mapstruct
1
0
Fork 0
mirror of https://github.com/mapstruct/mapstruct.git synced 2025-07-12 00:00:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

#1473 Make sure that the SPIs are lazy initialized in the AnnotationProcessorContext

Browse Source
This commit is contained in:
Filip Hrisafov 2018-05-03 23:15:23 +02:00 committed by GitHub
parent b6905d5168
commit 7a3f6d973e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
processor/src/main/java/org/mapstruct/ap/internal/util/AnnotationProcessorContext.java
View File

@ -43,14 +43,30 @@ public class AnnotationProcessorContext {
private List<AstModifyingAnnotationProcessor> astModifyingAnnotationProcessors; private List<AstModifyingAnnotationProcessor> astModifyingAnnotationProcessors;
private final BuilderProvider builderProvider; private BuilderProvider builderProvider;
private final AccessorNamingStrategy accessorNamingStrategy; private AccessorNamingStrategy accessorNamingStrategy;
private boolean initialized;
private AccessorNamingUtils accessorNaming; private AccessorNamingUtils accessorNaming;
private Elements elementUtils;
public AnnotationProcessorContext(Elements elementUtils) { public AnnotationProcessorContext(Elements elementUtils) {
astModifyingAnnotationProcessors = java.util.Collections.unmodifiableList( astModifyingAnnotationProcessors = java.util.Collections.unmodifiableList(
findAstModifyingAnnotationProcessors() ); findAstModifyingAnnotationProcessors() );
this.elementUtils = elementUtils;
}
/**
* Method for initializing the context with the SPIs. The reason why we do this is due to the fact that
* when custom SPI implementations are done and users don't set {@code proc:none} then our processor
* would be triggered. And this context will always get initialized and the SPI won't be found. However,
* if this is lazily evaluated it won't be a problem, as in the SPI implementation module there won't be any
* processing done.
*/
private void initialize() {
if ( initialized ) {
return;
}
AccessorNamingStrategy defaultAccessorNamingStrategy; AccessorNamingStrategy defaultAccessorNamingStrategy;
BuilderProvider defaultBuilderProvider; BuilderProvider defaultBuilderProvider;
@ -66,6 +82,7 @@ public class AnnotationProcessorContext {
this.accessorNamingStrategy = Services.get( AccessorNamingStrategy.class, defaultAccessorNamingStrategy ); this.accessorNamingStrategy = Services.get( AccessorNamingStrategy.class, defaultAccessorNamingStrategy );
this.builderProvider = Services.get( BuilderProvider.class, defaultBuilderProvider ); this.builderProvider = Services.get( BuilderProvider.class, defaultBuilderProvider );
this.accessorNaming = new AccessorNamingUtils( this.accessorNamingStrategy ); this.accessorNaming = new AccessorNamingUtils( this.accessorNamingStrategy );
this.initialized = true;
} }
private static List<AstModifyingAnnotationProcessor> findAstModifyingAnnotationProcessors() { private static List<AstModifyingAnnotationProcessor> findAstModifyingAnnotationProcessors() {
@ -87,14 +104,17 @@ public class AnnotationProcessorContext {
} }
public AccessorNamingUtils getAccessorNaming() { public AccessorNamingUtils getAccessorNaming() {
initialize();
return accessorNaming; return accessorNaming;
} }
public AccessorNamingStrategy getAccessorNamingStrategy() { public AccessorNamingStrategy getAccessorNamingStrategy() {
initialize();
return accessorNamingStrategy; return accessorNamingStrategy;
} }
public BuilderProvider getBuilderProvider() { public BuilderProvider getBuilderProvider() {
initialize();
return builderProvider; return builderProvider;
} }
} }