#2016 Update Checkstyle to 8.29

Adapt checkstyle configuration with new changes:
* Move cacheFile to Checker module
* Move LineLength to Checker module
* Use SuppressWithPlainTextCommentFilter

.gitignore

@@ -23,3 +23,4 @@ test-output
 
 # Misc.
 .DS_Store
+checkstyle.cache

build-config/src/main/resources/build-config/checkstyle.xml

@@ -15,6 +15,8 @@
         <property name="basedir" value="${basedir}"/>
     -->
 
+    <property name="cacheFile" value="${checkstyle.cache.file}"/>
+
     <!-- Checks that each Java package has a Javadoc file used for commenting. -->
     <!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage       -->
     <!--
@@ -29,6 +31,13 @@
 
     <module name="FileLength"/>
 
+    <module name="LineLength">
+        <property name="max" value="150"/>
+        <property name="fileExtensions" value="java" />
+    </module>
+
+    <module name="SuppressWithPlainTextCommentFilter"/>
+
     <!-- Following interprets the header file as regular expressions. -->
     <!-- <module name="RegexpHeader"/>                                -->
 
@@ -60,8 +69,6 @@
 
     <module name="TreeWalker">
 
-        <property name="cacheFile" value="${checkstyle.cache.file}"/>
-
         <module name="SuppressWarningsHolder"/>
 
         <!-- Checks for Javadoc comments.                     -->
@@ -115,9 +122,6 @@
 
         <!-- Checks for Size Violations.                    -->
         <!-- See http://checkstyle.sf.net/config_sizes.html -->
-        <module name="LineLength">
-            <property name="max" value="120"/>
-        </module>
         <module name="MethodLength"/>
         <module name="ParameterNumber">
             <property name="max" value="10"/>

parent/pom.xml

@@ -28,7 +28,7 @@
         <org.apache.maven.plugins.javadoc.version>3.1.0</org.apache.maven.plugins.javadoc.version>
         <org.springframework.version>4.0.3.RELEASE</org.springframework.version>
         <org.eclipse.tycho.compiler-jdt.version>0.26.0</org.eclipse.tycho.compiler-jdt.version>
-        <com.puppycrawl.tools.checkstyle.version>8.18</com.puppycrawl.tools.checkstyle.version>
+        <com.puppycrawl.tools.checkstyle.version>8.29</com.puppycrawl.tools.checkstyle.version>
         <add.release.arguments />
         <forkCount>1</forkCount>
         <assertj.version>3.11.1</assertj.version>
@@ -278,7 +278,7 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-checkstyle-plugin</artifactId>
-                    <version>3.0.0</version>
+                    <version>3.1.0</version>
                     <configuration>
                         <configLocation>build-config/checkstyle.xml</configLocation>
                         <consoleOutput>true</consoleOutput>

processor/src/main/java/org/mapstruct/ap/internal/conversion/SimpleConversion.java

@@ -45,7 +45,6 @@ public abstract class SimpleConversion implements ConversionProvider {
         return Collections.emptyList();
     }
 
-
     /**
      * Returns the conversion string from source to target. The placeholder {@code <SOURCE>} can be used to represent a
      * reference to the source value.

processor/src/main/java/org/mapstruct/ap/internal/model/HelperMethod.java

@@ -177,8 +177,6 @@ public abstract class HelperMethod implements Method {
         return true;
     }
 
-
-
     /**
      * There's currently only one parameter foreseen instead of a list of parameter
      *

processor/src/main/java/org/mapstruct/ap/internal/model/LifecycleMethodResolver.java

@@ -73,7 +73,6 @@ public final class LifecycleMethodResolver {
                         existingVariableNames );
     }
 
-
     /**
      * @param method the method to obtain the beforeMapping methods for
      * @param selectionParameters method selectionParameters

processor/src/main/java/org/mapstruct/ap/internal/model/ObjectFactoryMethodResolver.java

@@ -50,8 +50,6 @@ public class ObjectFactoryMethodResolver {
         return getFactoryMethod( method, method.getResultType(), selectionParameters, ctx );
     }
 
-
-
     /**
      * returns a no arg factory method
      *

processor/src/main/java/org/mapstruct/ap/internal/model/common/TypeFactory.java

@@ -145,7 +145,6 @@ public class TypeFactory {
         return getType( typeElement, isLiteral );
     }
 
-
     /**
      * Determines if the type with the given full qualified name is part of the classpath
      *
@@ -597,7 +596,6 @@ public class TypeFactory {
         return typeMirror;
     }
 
-
     /**
      * Whether the given type is ready to be processed or not. It can be processed if it is not of kind
      * {@link TypeKind#ERROR} and all {@link AstModifyingAnnotationProcessor}s (if any) indicated that they've fully

processor/src/main/java/org/mapstruct/ap/internal/processor/AnnotationBasedComponentModelProcessor.java

@@ -176,7 +176,6 @@ public abstract class AnnotationBasedComponentModelProcessor implements ModelEle
         );
     }
 
-
     /**
      * Removes duplicate constructor parameter annotations. If an annotation is already present on the constructor, it
      * does not have be defined on the constructor parameter, too. For example, for CDI, the javax.inject.Inject

processor/src/main/java/org/mapstruct/ap/spi/DefaultAccessorNamingStrategy.java

@@ -86,7 +86,6 @@ public class DefaultAccessorNamingStrategy implements AccessorNamingStrategy {
         return isNonBooleanGetterName || ( isBooleanGetterName && returnTypeIsBoolean );
     }
 
-
     /**
      * Returns {@code true} when the {@link ExecutableElement} is a setter method. A setter starts with 'set'. The
      * remainder of the name is supposed to reflect the property name.

processor/src/test/java/org/mapstruct/ap/test/accessibility/referenced/a/ReferencedMapperDefaultOther.java

@@ -8,7 +8,6 @@ package org.mapstruct.ap.test.accessibility.referenced.a;
 import org.mapstruct.ap.test.accessibility.referenced.ReferencedSource;
 import org.mapstruct.ap.test.accessibility.referenced.ReferencedTarget;
 
-
 /**
  *
  * @author Sjaak Derksen

processor/src/test/java/org/mapstruct/ap/test/bugs/_1170/PetMapper.java

@@ -29,7 +29,6 @@ public class PetMapper {
         .put( 3L, "cat" )
         .put( 4L, "dog" ).build();
 
-
     /**
      * method to be used when using an adder
      *

processor/src/test/java/org/mapstruct/ap/test/bugs/_375/Source.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.bugs._375;
 
-
 /**
  *
  * @author Sjaak Derksen

processor/src/test/java/org/mapstruct/ap/test/bugs/_513/TargetElement.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.bugs._513;
 
-
 /**
  *
  * @author Sjaak Derksen

processor/src/test/java/org/mapstruct/ap/test/bugs/_513/TargetKey.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.bugs._513;
 
-
 /**
  *
  * @author Sjaak Derksen

processor/src/test/java/org/mapstruct/ap/test/bugs/_513/TargetValue.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.bugs._513;
 
-
 /**
  *
  * @author Sjaak Derksen

processor/src/test/java/org/mapstruct/ap/test/bugs/_913/Issue913GetterMapperForCollectionsTest.java

@@ -198,8 +198,6 @@ public class Issue913GetterMapperForCollectionsTest {
         assertThat( domain2.getLongs() ).isEmpty();
     }
 
-
-
     /**
      * These assert check if non-null and default mapping is working as expected.
      *

processor/src/test/java/org/mapstruct/ap/test/collection/adder/PetMapper.java

@@ -31,7 +31,6 @@ public class PetMapper {
         .put( 3L, "cat" )
         .put( 4L, "dog" ).build();
 
-
     /**
      * method to be used when using an adder
      *

processor/src/test/java/org/mapstruct/ap/test/collection/adder/source/SingleElementSource.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.collection.adder.source;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/conversion/java8time/localdatetoxmlgregoriancalendarconversion/Source.java

@@ -7,7 +7,6 @@ package org.mapstruct.ap.test.conversion.java8time.localdatetoxmlgregoriancalend
 
 import javax.xml.datatype.XMLGregorianCalendar;
 
-
 /**
  * @author Andreas Gudian
  */

processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousannotatedfactorymethod/AmbiguousBarFactory.java

@@ -7,7 +7,6 @@ package org.mapstruct.ap.test.erroneous.ambiguousannotatedfactorymethod;
 
 import org.mapstruct.ObjectFactory;
 
-
 /**
  * @author Remo Meier
  */

processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousannotatedfactorymethod/Foo.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.erroneous.ambiguousannotatedfactorymethod;
 
-
 /**
  * @author Remo Meier
  */

processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousannotatedfactorymethod/Source.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.erroneous.ambiguousannotatedfactorymethod;
 
-
 /**
  * @author Remo Meier
  */

processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousannotatedfactorymethod/Target.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.erroneous.ambiguousannotatedfactorymethod;
 
-
 /**
  * @author Remo Meier
  */

processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Foo.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Source.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Target.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/a/BarFactory.java

@@ -7,7 +7,6 @@ package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod.a;
 
 import org.mapstruct.ap.test.erroneous.ambiguousfactorymethod.Bar;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/generics/AbstractTo.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.generics;
 
-
 /**
  * @author Andreas Gudian
  */

processor/src/test/java/org/mapstruct/ap/test/generics/TargetTo.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.generics;
 
-
 /**
  * @author Andreas Gudian
  *

processor/src/test/java/org/mapstruct/ap/test/nestedsourceproperties/_target/AdderUsageObserver.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.nestedsourceproperties._target;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/nestedsourceproperties/_target/ChartEntryLabel.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.nestedsourceproperties._target;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/nestedsourceproperties/source/Song.java

@@ -7,7 +7,6 @@ package org.mapstruct.ap.test.nestedsourceproperties.source;
 
 import java.util.List;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/nullcheck/MyLongWrapper.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.nullcheck;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/references/Target.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.references;
 
-
 /**
  * @author Andreas Gudian
  *

processor/src/test/java/org/mapstruct/ap/test/selection/primitives/PrimitiveMapper.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.selection.primitives;
 
-
 /**
  * @author Sjaak Derksen
  *

processor/src/test/java/org/mapstruct/ap/test/source/constants/Source1.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.source.constants;
 
-
 /**
  *
  * @author Sjaak Derksen

processor/src/test/java/org/mapstruct/ap/test/source/constants/Source2.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.source.constants;
 
-
 /**
  *
  * @author Sjaak Derksen

processor/src/test/java/org/mapstruct/ap/test/source/constants/Target2.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.source.constants;
 
-
 /**
  *
  * @author Sjaak Derksen

processor/src/test/java/org/mapstruct/ap/test/template/Source.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.template;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/test/template/Target.java

@@ -5,7 +5,6 @@
  */
 package org.mapstruct.ap.test.template;
 
-
 /**
  * @author Sjaak Derksen
  */

processor/src/test/java/org/mapstruct/ap/testutil/runner/GeneratedSource.java

@@ -57,7 +57,6 @@ public class GeneratedSource implements TestRule {
         GeneratedSource.compilingStatement.remove();
     }
 
-
     /**
      * Adds more mappers that need to be compared.
      *

processor/src/test/resources/checkstyle-for-generated-sources.xml

@@ -7,6 +7,8 @@
 <!-- Based on sun_checks.xml from the CheckStyle distribution -->
 
 <module name="Checker">
+
+    <property name="cacheFile" value="${checkstyle.cache.file}"/>
     <!--
         If you set the basedir property below, then all reported file
         names will be relative to the specified directory. See
@@ -56,8 +58,6 @@
 
     <module name="TreeWalker">
 
-        <property name="cacheFile" value="${checkstyle.cache.file}"/>
-
         <!-- Checks for Naming Conventions.                  -->
         <!-- See http://checkstyle.sf.net/config_naming.html -->
    <!-- <module name="ConstantName"/>