third_codes/mapstruct
1
0
Fork 0
mirror of https://github.com/mapstruct/mapstruct.git synced 2025-07-12 00:00:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

#220 Avoiding negated method name

Browse Source
This commit is contained in:
Gunnar Morling 2014-06-06 20:10:34 +02:00
parent a3d0e420eb
commit a1cdd11bd5
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
processor/src/main/java/org/mapstruct/ap/model/common/Type.java
View File

@ -165,7 +165,7 @@ public class Type extends ModelElement implements Comparable<Type> {
* implementation type is {@code HashSet<String>}. * implementation type is {@code HashSet<String>}.
* *
* @return The implementation type to be instantiated in case this type is an interface iterable, collection or map * @return The implementation type to be instantiated in case this type is an interface iterable, collection or map
* type, {@code null} otherwise. * type, {@code null} otherwise.
*/ */
public Type getImplementationType() { public Type getImplementationType() {
return implementationType; return implementationType;
@ -302,7 +302,8 @@ public class Type extends ModelElement implements Comparable<Type> {
// a getter could substitute the setter in that case and act as setter. // a getter could substitute the setter in that case and act as setter.
// (assuming it is initialized) // (assuming it is initialized)
for ( ExecutableElement getterMethod : getterMethods ) { for ( ExecutableElement getterMethod : getterMethods ) {
if ( hasNoSetterMethod( getterMethod, setterMethods ) && isCollectionOrMap( getterMethod ) ) { if ( isCollectionOrMap( getterMethod ) &&
!correspondingSetterMethodExists( getterMethod, setterMethods ) ) {
result.add( getterMethod ); result.add( getterMethod );
} }
} }
@ -312,15 +313,18 @@ public class Type extends ModelElement implements Comparable<Type> {
return alternativeTargetAccessors; return alternativeTargetAccessors;
} }
private boolean hasNoSetterMethod(ExecutableElement getterMethod, List<ExecutableElement> setterMethods) { private boolean correspondingSetterMethodExists(ExecutableElement getterMethod,
List<ExecutableElement> setterMethods) {
String getterPropertyName = Executables.getPropertyName( getterMethod ); String getterPropertyName = Executables.getPropertyName( getterMethod );
for ( ExecutableElement setterMethod : setterMethods ) { for ( ExecutableElement setterMethod : setterMethods ) {
String setterPropertyName = Executables.getPropertyName( setterMethod ); String setterPropertyName = Executables.getPropertyName( setterMethod );
if ( getterPropertyName.equals( setterPropertyName ) ) { if ( getterPropertyName.equals( setterPropertyName ) ) {
return false; return true;
} }
} }
return true;
return false;
} }
private boolean isCollectionOrMap(ExecutableElement getterMethod) { private boolean isCollectionOrMap(ExecutableElement getterMethod) {