third_codes/mapstruct
1
0
Fork 0
mirror of https://github.com/mapstruct/mapstruct.git synced 2025-07-12 00:00:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

#2674: Add check if method without implementation doesn’t have @AfterMapping / @BeforeMapping annotation

Browse Source
This commit is contained in:
Justyna 2022-01-24 14:17:24 +01:00 committed by GitHub
parent 0a8e9b738c
commit b22efd9ad7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 136 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
processor/src/main/java/org/mapstruct/ap/internal/processor/MethodRetrievalProcessor.java
View File

@ -564,6 +564,16 @@ public class MethodRetrievalProcessor implements ModelElementProcessor<Void, Lis
}
}
if ( Executables.isAfterMappingMethod( method ) ) {
messager.printMessage( method, Message.RETRIEVAL_AFTER_METHOD_NOT_IMPLEMENTED );
return false;
}
if ( Executables.isBeforeMappingMethod( method ) ) {
messager.printMessage( method, Message.RETRIEVAL_BEFORE_METHOD_NOT_IMPLEMENTED );
return false;
}
return true;
}

2
processor/src/main/java/org/mapstruct/ap/internal/util/Message.java
View File

@ -167,6 +167,8 @@ public enum Message {
RETRIEVAL_WILDCARD_EXTENDS_BOUND_RESULT( "Can't generate mapping method for a wildcard extends bound result." ),
RETRIEVAL_CONTEXT_PARAMS_WITH_SAME_TYPE( "The types of @Context parameters must be unique." ),
RETRIEVAL_MAPPER_USES_CYCLE( "The mapper %s is referenced itself in Mapper#uses.", Diagnostic.Kind.WARNING ),
RETRIEVAL_AFTER_METHOD_NOT_IMPLEMENTED( "@AfterMapping can only be applied to an implemented method." ),
RETRIEVAL_BEFORE_METHOD_NOT_IMPLEMENTED( "@BeforeMapping can only be applied to an implemented method." ),
INHERITINVERSECONFIGURATION_DUPLICATES( "Several matching inverse methods exist: %s(). Specify a name explicitly." ),
INHERITINVERSECONFIGURATION_INVALID_NAME( "None of the candidates %s() matches given name: \"%s\"." ),

28
processor/src/test/java/org/mapstruct/ap/test/bugs/_2674/ErroneousSourceTargetMapping.java Normal file
View File

@ -0,0 +1,28 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.ap.test.bugs._2674;
import org.mapstruct.AfterMapping;
import org.mapstruct.BeforeMapping;
import org.mapstruct.Mapper;
import org.mapstruct.MappingTarget;
import org.mapstruct.factory.Mappers;
@Mapper
interface ErroneousSourceTargetMapping {
ErroneousSourceTargetMapping INSTANCE = Mappers.getMapper( ErroneousSourceTargetMapping.class );
@BeforeMapping
void beforeMappingMethod(Target target, @MappingTarget Source source);
@AfterMapping
void afterMappingMethod(Source source, @MappingTarget Target target);
Target toTarget(Source source);
Source toSource(Target target);
}

40
processor/src/test/java/org/mapstruct/ap/test/bugs/_2674/Issue2674Test.java Normal file
View File

@ -0,0 +1,40 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.ap.test.bugs._2674;
import org.mapstruct.ap.testutil.IssueKey;
import org.mapstruct.ap.testutil.ProcessorTest;
import org.mapstruct.ap.testutil.WithClasses;
import org.mapstruct.ap.testutil.compilation.annotation.CompilationResult;
import org.mapstruct.ap.testutil.compilation.annotation.Diagnostic;
import org.mapstruct.ap.testutil.compilation.annotation.ExpectedCompilationOutcome;
import static javax.tools.Diagnostic.Kind;
/**
* @author Justyna Kubica-Ledzion
*/
@IssueKey("2674")
@WithClasses({ Source.class, Target.class, ErroneousSourceTargetMapping.class })
public class Issue2674Test {
@ProcessorTest
@ExpectedCompilationOutcome(
value = CompilationResult.FAILED,
diagnostics = {
@Diagnostic(type = ErroneousSourceTargetMapping.class,
kind = Kind.ERROR,
line = 20,
message = "@BeforeMapping can only be applied to an implemented method."),
@Diagnostic(type = ErroneousSourceTargetMapping.class,
kind = Kind.ERROR,
line = 23,
message = "@AfterMapping can only be applied to an implemented method.")
}
)
public void shouldRaiseErrorIfThereIsNoAfterOrBeforeMethodImplementation() {
}
}

28
processor/src/test/java/org/mapstruct/ap/test/bugs/_2674/Source.java Normal file
View File

@ -0,0 +1,28 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.ap.test.bugs._2674;
public class Source {
private int id;
private String name;
public int getId() {
return id;
}
public void setId(int id) {
this.id = id;
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
}

28
processor/src/test/java/org/mapstruct/ap/test/bugs/_2674/Target.java Normal file
View File

@ -0,0 +1,28 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.ap.test.bugs._2674;
public class Target {
private int id;
private String name;
public int getId() {
return id;
}
public void setId(int id) {
this.id = id;
}
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
}