third_codes/mapstruct
1
0
Fork 0
mirror of https://github.com/mapstruct/mapstruct.git synced 2025-07-12 00:00:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

use == instead of equals when comparing enum instances

Browse Source
This commit is contained in:
Andreas Gudian 2014-10-21 20:06:17 +02:00
parent 8c3e32472b
commit ba10a8c123
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
processor/src/main/java/org/mapstruct/ap/model/BeanMappingMethod.java
View File

@ -102,15 +102,15 @@ public class BeanMappingMethod extends MappingMethod {
// A target access is in general a setter method on the target object. However, in case of collections, // A target access is in general a setter method on the target object. However, in case of collections,
// the current target accessor can also be a getter method. // the current target accessor can also be a getter method.
// The following if block, checks if the target accessor should be overruled by an add method. // The following if block, checks if the target accessor should be overruled by an add method.
if ( cmStrategy.equals( CollectionMappingStrategy.SETTER_PREFERRED ) if ( cmStrategy == CollectionMappingStrategy.SETTER_PREFERRED
|| cmStrategy.equals( CollectionMappingStrategy.ADDER_PREFERRED ) ) { || cmStrategy == CollectionMappingStrategy.ADDER_PREFERRED ) {
// first check if there's a setter method. // first check if there's a setter method.
ExecutableElement adderMethod = null; ExecutableElement adderMethod = null;
if ( Executables.isSetterMethod( targetAccessor ) ) { if ( Executables.isSetterMethod( targetAccessor ) ) {
Type targetType = ctx.getTypeFactory().getSingleParameter( targetAccessor ).getType(); Type targetType = ctx.getTypeFactory().getSingleParameter( targetAccessor ).getType();
// ok, the current accessor is a setter. So now the strategy determines what to use // ok, the current accessor is a setter. So now the strategy determines what to use
if ( cmStrategy.equals( CollectionMappingStrategy.ADDER_PREFERRED ) ) { if ( cmStrategy == CollectionMappingStrategy.ADDER_PREFERRED ) {
adderMethod = method.getResultType().getAdderForType( targetType, targetPropertyName ); adderMethod = method.getResultType().getAdderForType( targetType, targetPropertyName );
} }
} }