diff --git a/processor/src/test/java/org/mapstruct/ap/test/collection/erronuous/ErronuousCollectionMappingTest.java b/processor/src/test/java/org/mapstruct/ap/test/collection/erronuous/ErronuousCollectionMappingTest.java index e6dda2f0d..ac90935b5 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/collection/erronuous/ErronuousCollectionMappingTest.java +++ b/processor/src/test/java/org/mapstruct/ap/test/collection/erronuous/ErronuousCollectionMappingTest.java @@ -28,6 +28,11 @@ import org.mapstruct.ap.testutil.compilation.annotation.Diagnostic; import org.mapstruct.ap.testutil.compilation.annotation.ExpectedCompilationOutcome; import org.testng.annotations.Test; +/** + * Test for illegal mappings between iterable and non-iterable types. + * + * @author Gunnar Morling + */ @WithClasses({ ErronuousMapper.class }) public class ErronuousCollectionMappingTest extends MapperTestBase { @@ -36,8 +41,14 @@ public class ErronuousCollectionMappingTest extends MapperTestBase { @ExpectedCompilationOutcome( value = CompilationResult.FAILED, diagnostics = { - @Diagnostic(type = ErronuousMapper.class, kind = Kind.ERROR, line = 28), - @Diagnostic(type = ErronuousMapper.class, kind = Kind.ERROR, line = 30) + @Diagnostic(type = ErronuousMapper.class, + kind = Kind.ERROR, + line = 28, + messageRegExp = "Can't generate mapping method from iterable type to non-iterable type\\."), + @Diagnostic(type = ErronuousMapper.class, + kind = Kind.ERROR, + line = 30, + messageRegExp = "Can't generate mapping method from non-iterable type to iterable type\\.") } ) public void shouldFailToGenerateMappingFromListToString() { diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/attributereference/ErroneousMappingsTest.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/attributereference/ErroneousMappingsTest.java index 1372c241c..74eccdf2c 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/attributereference/ErroneousMappingsTest.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/attributereference/ErroneousMappingsTest.java @@ -28,6 +28,11 @@ import org.mapstruct.ap.testutil.compilation.annotation.Diagnostic; import org.mapstruct.ap.testutil.compilation.annotation.ExpectedCompilationOutcome; import org.testng.annotations.Test; +/** + * Test for using unknown attributes in {@code @Mapping}. + * + * @author Gunnar Morling + */ @WithClasses({ ErroneousMapper.class, Source.class, Target.class, AnotherTarget.class }) public class ErroneousMappingsTest extends MapperTestBase { @@ -36,8 +41,14 @@ public class ErroneousMappingsTest extends MapperTestBase { @ExpectedCompilationOutcome( value = CompilationResult.FAILED, diagnostics = { - @Diagnostic(type = ErroneousMapper.class, kind = Kind.ERROR, line = 27), - @Diagnostic(type = ErroneousMapper.class, kind = Kind.ERROR, line = 30) + @Diagnostic(type = ErroneousMapper.class, + kind = Kind.ERROR, + line = 27, + messageRegExp = "Unknown property \"bar\" in return type.*"), + @Diagnostic(type = ErroneousMapper.class, + kind = Kind.ERROR, + line = 30, + messageRegExp = "Unknown property \"bar\" in parameter type.*") } ) public void shouldFailToGenerateMappings() { diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/typemismatch/ErroneousMappingsTest.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/typemismatch/ErroneousMappingsTest.java index 52dae78c2..ad31b6a91 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/typemismatch/ErroneousMappingsTest.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/typemismatch/ErroneousMappingsTest.java @@ -28,6 +28,11 @@ import org.mapstruct.ap.testutil.compilation.annotation.Diagnostic; import org.mapstruct.ap.testutil.compilation.annotation.ExpectedCompilationOutcome; import org.testng.annotations.Test; +/** + * Tests failures expected for unmappable attributes. + * + * @author Gunnar Morling + */ @WithClasses({ ErroneousMapper.class, Source.class, Target.class }) public class ErroneousMappingsTest extends MapperTestBase { @@ -36,10 +41,22 @@ public class ErroneousMappingsTest extends MapperTestBase { @ExpectedCompilationOutcome( value = CompilationResult.FAILED, diagnostics = { - @Diagnostic(type = ErroneousMapper.class, kind = Kind.ERROR, line = 26), - @Diagnostic(type = ErroneousMapper.class, kind = Kind.ERROR, line = 28), - @Diagnostic(type = ErroneousMapper.class, kind = Kind.ERROR, line = 30), - @Diagnostic(type = ErroneousMapper.class, kind = Kind.ERROR, line = 32) + @Diagnostic(type = ErroneousMapper.class, + kind = Kind.ERROR, + line = 26, + messageRegExp = "Can't map property \"boolean foo\" to \"int foo\"\\."), + @Diagnostic(type = ErroneousMapper.class, + kind = Kind.ERROR, + line = 28, + messageRegExp = "Can't map property \"int foo\" to \"boolean foo\"\\."), + @Diagnostic(type = ErroneousMapper.class, + kind = Kind.ERROR, + line = 30, + messageRegExp = "Can't generate mapping method with primitive return type\\."), + @Diagnostic(type = ErroneousMapper.class, + kind = Kind.ERROR, + line = 32, + messageRegExp = "Can't generate mapping method with primitive parameter type\\.") } ) public void shouldFailToGenerateMappings() {