diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/Mapper.java b/processor/src/main/java/org/mapstruct/ap/internal/model/Mapper.java index 7e58580de..7c270c1bf 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/Mapper.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/Mapper.java @@ -193,8 +193,6 @@ public class Mapper extends GeneratedType { /** * Checks if the mapper has a custom implementation that is a custom suffix of an explicit destination package. - * - * @return */ public boolean hasCustomImplementation() { return customImplName || customPackage; diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/MappingMethod.java b/processor/src/main/java/org/mapstruct/ap/internal/model/MappingMethod.java index ab5026fb7..a8fa9381d 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/MappingMethod.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/MappingMethod.java @@ -55,11 +55,6 @@ public abstract class MappingMethod extends ModelElement { /** * constructor to be overloaded when local variable names are required prior to calling this constructor. (e.g. for * property mappings). It is supposed to be initialized with at least the parameter names. - * - * @param method method - * @param existingVariableNames existingVariableNames - * @param beforeMappingReferences - * @param afterMappingReferences */ protected MappingMethod(Method method, Collection existingVariableNames, List beforeMappingReferences, diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/PropertyMapping.java b/processor/src/main/java/org/mapstruct/ap/internal/model/PropertyMapping.java index bf8a87318..9e22f69e0 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/PropertyMapping.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/PropertyMapping.java @@ -31,7 +31,6 @@ import java.util.Set; import javax.lang.model.element.ExecutableElement; import javax.lang.model.type.DeclaredType; -import javax.lang.model.type.TypeMirror; import org.mapstruct.ap.internal.model.assignment.AdderWrapper; import org.mapstruct.ap.internal.model.assignment.ArrayCopyWrapper; @@ -169,9 +168,6 @@ public class PropertyMapping extends ModelElement { // initial properties private String dateFormat; private String defaultValue; - private List qualifiers; - private List qualifyingNames; - private TypeMirror resultType; private SourceReference sourceReference; private SelectionParameters selectionParameters; @@ -181,11 +177,6 @@ public class PropertyMapping extends ModelElement { } public PropertyMappingBuilder selectionParameters(SelectionParameters selectionParameters) { - if ( selectionParameters != null ) { - this.qualifiers = selectionParameters.getQualifiers(); - this.qualifyingNames = selectionParameters.getQualifyingNames(); - this.resultType = selectionParameters.getResultType(); - } this.selectionParameters = selectionParameters; return this; } diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/source/selector/CreateOrUpdateSelector.java b/processor/src/main/java/org/mapstruct/ap/internal/model/source/selector/CreateOrUpdateSelector.java index 584615c92..1b7573f8e 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/source/selector/CreateOrUpdateSelector.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/source/selector/CreateOrUpdateSelector.java @@ -46,7 +46,6 @@ public class CreateOrUpdateSelector implements MethodSelector { Type sourceType, Type targetType, SelectionCriteria criteria) { - boolean isCreateMethod = mappingMethod.getMappingTargetParameter() == null; List createCandidates = new ArrayList(); List updateCandidates = new ArrayList(); for ( T method : methods ) { diff --git a/processor/src/main/java/org/mapstruct/ap/internal/util/TypeHierarchyErroneousException.java b/processor/src/main/java/org/mapstruct/ap/internal/util/TypeHierarchyErroneousException.java index bd82a8702..16598618a 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/util/TypeHierarchyErroneousException.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/util/TypeHierarchyErroneousException.java @@ -27,6 +27,7 @@ import javax.lang.model.element.TypeElement; * */ public class TypeHierarchyErroneousException extends RuntimeException { + private static final long serialVersionUID = 1L; private TypeElement element;