#410 Small template improvement, removing empty lines between fields

core-common/src/main/java/org/mapstruct/BeanMapping.java

@@ -27,6 +27,8 @@ import java.lang.annotation.Target;
 /**
  * Configures the mapping between two bean types.
  *
+ * <p>Note: either @BeanMapping#resultType or @BeanMapping#qualifiedBy must be specified</p>
+ *
  * @author Sjaak Derksen
  */
 @Target( ElementType.METHOD )

processor/src/main/java/org/mapstruct/ap/model/source/BeanMapping.java

@@ -46,7 +46,7 @@ public class BeanMapping {
         if ( !resultTypeIsDefined && beanMapping.qualifiedBy().isEmpty() ) {
             messager.printMessage(
                 Diagnostic.Kind.ERROR,
-                "'resultType' and 'qualifiedBy' are are are undefined in @BeanMapping, "
+                "'resultType' and 'qualifiedBy' are undefined in @BeanMapping, "
                 + "define at least one of them.",
                 method
             );

processor/src/main/resources/org.mapstruct.ap.model.GeneratedType.ftl

@@ -33,10 +33,11 @@ import ${importedType.importName};
 <#nt><@includeModel object=annotation/>
 </#list>
 <#lt>${accessibility.keyword} class ${name}<#if superClassName??> extends ${superClassName}</#if><#if interfaceName??> implements ${interfaceName}</#if> {
-<#list fields as field>
 
+<#list fields as field>
 <#nt>    <@includeModel object=field/>
 </#list>
+
 <#list methods as method>
 <#nt>    <@includeModel object=method/>
 </#list>

processor/src/test/java/org/mapstruct/ap/test/collection/erroneous/ErroneousCollectionMappingTest.java

@@ -65,7 +65,7 @@ public class ErroneousCollectionMappingTest {
             @Diagnostic(type = EmptyItererableMappingMapper.class,
                 kind = Kind.ERROR,
                 line = 35,
-                messageRegExp = "'dateformat' and 'qualifiedBy' are are are undefined in @IterableMapping, "
+                messageRegExp = "'dateformat' and 'qualifiedBy' are undefined in @IterableMapping, "
                     + "define at least one of them.")
         }
     )

processor/src/test/java/org/mapstruct/ap/test/selection/qualifier/QualifierTest.java

@@ -186,7 +186,7 @@ public class QualifierTest {
                 @Diagnostic( type = ErroneousMovieFactoryMapper.class,
                         kind = Kind.ERROR,
                         line = 37,
-                        messageRegExp = "'resultType' and 'qualifiedBy' are are are undefined in @BeanMapping, "
+                        messageRegExp = "'resultType' and 'qualifiedBy' are undefined in @BeanMapping, "
                 + "define at least one of them." )
             }
     )