diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java b/processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java index 5089d2717..458804bee 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java @@ -8,7 +8,6 @@ package org.mapstruct.ap.internal.model; import java.text.MessageFormat; import java.util.ArrayList; import java.util.Collection; -import java.util.Collections; import java.util.Comparator; import java.util.HashMap; import java.util.HashSet; @@ -371,11 +370,8 @@ public class BeanMappingMethod extends NormalTypeMappingMethod { ); } else { - Collections.sort( - propertyMappings, - Comparator.comparingInt( propertyMapping -> - graphAnalyzer.getTraversalSequence( propertyMapping.getName() ) ) - ); + propertyMappings.sort( Comparator.comparingInt( propertyMapping -> + graphAnalyzer.getTraversalSequence( propertyMapping.getName() ) ) ); } } diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/LifecycleCallbackMethodReference.java b/processor/src/main/java/org/mapstruct/ap/internal/model/LifecycleCallbackMethodReference.java index 10fb2d9c7..c47fd258c 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/LifecycleCallbackMethodReference.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/LifecycleCallbackMethodReference.java @@ -80,17 +80,11 @@ public class LifecycleCallbackMethodReference extends MethodReference { @Override public Set getImportTypes() { - return declaringType != null ? Collections.asSet( declaringType ) : java.util.Collections. emptySet(); + return declaringType != null ? Collections.asSet( declaringType ) : java.util.Collections.emptySet(); } public boolean hasMappingTargetParameter() { - for ( ParameterBinding param : getParameterBindings() ) { - if ( param.isMappingTarget() ) { - return true; - } - } - - return false; + return getParameterBindings().stream().anyMatch( ParameterBinding::isMappingTarget ); } /** diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/ObjectFactoryMethodResolver.java b/processor/src/main/java/org/mapstruct/ap/internal/model/ObjectFactoryMethodResolver.java index 5a0f72fb5..b64dd8888 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/ObjectFactoryMethodResolver.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/ObjectFactoryMethodResolver.java @@ -76,7 +76,7 @@ public class ObjectFactoryMethodResolver { selectors.getMatchingMethods( method, getAllAvailableMethods( method, ctx.getSourceModel() ), - java.util.Collections. emptyList(), + java.util.Collections.emptyList(), alternativeTarget, SelectionCriteria.forFactoryMethods( selectionParameters ) ); diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/source/ParameterProvidedMethods.java b/processor/src/main/java/org/mapstruct/ap/internal/model/source/ParameterProvidedMethods.java index 28817bc43..6552e4350 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/source/ParameterProvidedMethods.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/source/ParameterProvidedMethods.java @@ -23,7 +23,7 @@ import org.mapstruct.ap.internal.model.common.Parameter; */ public class ParameterProvidedMethods { private static final ParameterProvidedMethods EMPTY = - new ParameterProvidedMethods( Collections.> emptyMap() ); + new ParameterProvidedMethods( Collections.emptyMap() ); private final Map> parameterToProvidedMethods; private final Map methodToProvidingParameter; diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/source/SourceMethod.java b/processor/src/main/java/org/mapstruct/ap/internal/model/source/SourceMethod.java index 32bd540f1..ae6760ae2 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/source/SourceMethod.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/source/SourceMethod.java @@ -454,13 +454,7 @@ public class SourceMethod implements Method { * @return {@code true} if the parameter list contains a parameter annotated with {@code @TargetType} */ public static boolean containsTargetTypeParameter(List parameters) { - for ( Parameter param : parameters ) { - if ( param.isTargetType() ) { - return true; - } - } - - return false; + return parameters.stream().anyMatch( Parameter::isTargetType ); } @Override diff --git a/processor/src/main/java/org/mapstruct/ap/internal/util/workarounds/EclipseAsMemberOfWorkaround.java b/processor/src/main/java/org/mapstruct/ap/internal/util/workarounds/EclipseAsMemberOfWorkaround.java index 739246a6c..ab0d68172 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/util/workarounds/EclipseAsMemberOfWorkaround.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/util/workarounds/EclipseAsMemberOfWorkaround.java @@ -6,7 +6,6 @@ package org.mapstruct.ap.internal.util.workarounds; import java.util.ArrayList; -import java.util.Collections; import java.util.Comparator; import java.util.HashSet; import java.util.List; @@ -73,7 +72,7 @@ final class EclipseAsMemberOfWorkaround { candidatesFromInterfaces ); // there can be multiple matches for the same method name from adjacent interface hierarchies. - Collections.sort( candidatesFromInterfaces, MostSpecificMethodBindingComparator.INSTANCE ); + candidatesFromInterfaces.sort( MostSpecificMethodBindingComparator.INSTANCE ); if ( !candidatesFromInterfaces.isEmpty() ) { // return the most specific match