From f122daec6d89873a761abecdcd7fdf56f1de00d5 Mon Sep 17 00:00:00 2001 From: Gunnar Morling Date: Sun, 9 Feb 2014 11:21:52 +0100 Subject: [PATCH] #81 Formatting --- .../mapstruct/ap/model/source/Mapping.java | 1 - .../org/mapstruct/ap/model/source/Method.java | 5 +- .../ap/model/source/MethodMatcher.java | 1 - ...nnotationBasedComponentModelProcessor.java | 1 - .../ap/processor/MapperCreationProcessor.java | 69 ++++++++++--------- .../processor/MethodRetrievalProcessor.java | 5 +- ...g.mapstruct.ap.model.BeanMappingMethod.ftl | 2 +- .../erroneous/ambiguousfactorymethod/Bar.java | 3 +- .../ambiguousfactorymethod/FactoryTest.java | 22 +++--- .../erroneous/ambiguousfactorymethod/Foo.java | 1 - .../ambiguousfactorymethod/Source.java | 3 +- .../SourceTargetMapperAndBarFactory.java | 7 +- .../ambiguousfactorymethod/Target.java | 1 - .../ambiguousfactorymethod/a/BarFactory.java | 3 +- .../org/mapstruct/ap/test/factories/Bar1.java | 3 +- .../org/mapstruct/ap/test/factories/Bar2.java | 3 +- .../org/mapstruct/ap/test/factories/Bar3.java | 3 +- .../ap/test/factories/CustomList.java | 1 - .../ap/test/factories/CustomListImpl.java | 3 +- .../ap/test/factories/CustomMap.java | 1 - .../ap/test/factories/CustomMapImpl.java | 3 +- .../ap/test/factories/FactoryTest.java | 26 +++---- .../org/mapstruct/ap/test/factories/Foo1.java | 1 - .../org/mapstruct/ap/test/factories/Foo2.java | 1 - .../org/mapstruct/ap/test/factories/Foo3.java | 1 - .../mapstruct/ap/test/factories/Source.java | 11 ++- .../SourceTargetMapperAndBar2Factory.java | 14 ++-- .../mapstruct/ap/test/factories/Target.java | 9 ++- .../ap/test/factories/a/BarFactory.java | 3 +- .../ap/test/factories/b/BarFactory.java | 3 +- 30 files changed, 94 insertions(+), 116 deletions(-) diff --git a/processor/src/main/java/org/mapstruct/ap/model/source/Mapping.java b/processor/src/main/java/org/mapstruct/ap/model/source/Mapping.java index 7fa273395..59ae76025 100644 --- a/processor/src/main/java/org/mapstruct/ap/model/source/Mapping.java +++ b/processor/src/main/java/org/mapstruct/ap/model/source/Mapping.java @@ -22,7 +22,6 @@ import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; - import javax.lang.model.element.AnnotationMirror; import javax.lang.model.element.AnnotationValue; import javax.lang.model.element.Element; diff --git a/processor/src/main/java/org/mapstruct/ap/model/source/Method.java b/processor/src/main/java/org/mapstruct/ap/model/source/Method.java index b3663e7b6..438503669 100644 --- a/processor/src/main/java/org/mapstruct/ap/model/source/Method.java +++ b/processor/src/main/java/org/mapstruct/ap/model/source/Method.java @@ -22,7 +22,6 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.Map; - import javax.lang.model.element.ExecutableElement; import javax.lang.model.element.Modifier; @@ -76,7 +75,7 @@ public class Method { } public static Method forFactoryMethod(Type declaringMapper, ExecutableElement executable, - Type returnType ) { + Type returnType) { return new Method( declaringMapper, @@ -89,8 +88,6 @@ public class Method { ); } - - private Method(Type declaringMapper, ExecutableElement executable, List parameters, Type returnType, Map> mappings, IterableMapping iterableMapping, MapMapping mapMapping) { this.declaringMapper = declaringMapper; diff --git a/processor/src/main/java/org/mapstruct/ap/model/source/MethodMatcher.java b/processor/src/main/java/org/mapstruct/ap/model/source/MethodMatcher.java index 3a9703b67..ff298c7ea 100644 --- a/processor/src/main/java/org/mapstruct/ap/model/source/MethodMatcher.java +++ b/processor/src/main/java/org/mapstruct/ap/model/source/MethodMatcher.java @@ -21,7 +21,6 @@ package org.mapstruct.ap.model.source; import java.util.HashMap; import java.util.List; import java.util.Map; - import javax.lang.model.element.TypeElement; import javax.lang.model.element.TypeParameterElement; import javax.lang.model.element.VariableElement; diff --git a/processor/src/main/java/org/mapstruct/ap/processor/AnnotationBasedComponentModelProcessor.java b/processor/src/main/java/org/mapstruct/ap/processor/AnnotationBasedComponentModelProcessor.java index fdfd1a097..c5e536db5 100644 --- a/processor/src/main/java/org/mapstruct/ap/processor/AnnotationBasedComponentModelProcessor.java +++ b/processor/src/main/java/org/mapstruct/ap/processor/AnnotationBasedComponentModelProcessor.java @@ -19,7 +19,6 @@ package org.mapstruct.ap.processor; import java.util.ListIterator; - import javax.lang.model.element.TypeElement; import org.mapstruct.ap.model.Annotation; diff --git a/processor/src/main/java/org/mapstruct/ap/processor/MapperCreationProcessor.java b/processor/src/main/java/org/mapstruct/ap/processor/MapperCreationProcessor.java index 423cc7899..1ef4251df 100644 --- a/processor/src/main/java/org/mapstruct/ap/processor/MapperCreationProcessor.java +++ b/processor/src/main/java/org/mapstruct/ap/processor/MapperCreationProcessor.java @@ -27,6 +27,7 @@ import java.util.LinkedList; import java.util.List; import java.util.Map; import java.util.Set; + import javax.annotation.processing.Messager; import javax.lang.model.element.Element; import javax.lang.model.element.ExecutableElement; @@ -180,7 +181,7 @@ public class MapperCreationProcessor implements ModelElementProcessor mapperReferences, List methods, - Type returnType) { + Type returnType) { MethodReference result = null; for ( Method method : methods ) { if ( !method.requiresImplementation() && !method.isIterableMapping() && !method.isMapMapping() && method.getMappings().isEmpty() && method.getParameters().isEmpty() ) { - if ( method.getReturnType().equals( returnType ) ) { - if ( result == null ) { - MapperReference mapperReference = null; - for ( MapperReference ref : mapperReferences ) { - if ( ref.getMapperType().equals( method.getDeclaringMapper() ) ) { - mapperReference = ref; - break; - } + if ( method.getReturnType().equals( returnType ) ) { + if ( result == null ) { + MapperReference mapperReference = null; + for ( MapperReference ref : mapperReferences ) { + if ( ref.getMapperType().equals( method.getDeclaringMapper() ) ) { + mapperReference = ref; + break; } - - result = new MethodReference(method, mapperReference); } - else { - messager.printMessage( - Kind.ERROR, - String.format( - "Ambigious factory method: \"%s\" conflicts with \"%s\".", - result, - method - ), - method.getExecutable() - ); - } - } - } + + result = new MethodReference( method, mapperReference ); + } + else { + messager.printMessage( + Kind.ERROR, + String.format( + "Ambigious factory methods: \"%s\" conflicts with \"%s\".", + result, + method + ), + method.getExecutable() + ); + } + } + } } return result; } @@ -333,7 +334,7 @@ public class MapperCreationProcessor implements ModelElementProcessor mapperReferences, List methods, - Method method, ReportingPolicy unmappedTargetPolicy) { + Method method, ReportingPolicy unmappedTargetPolicy) { List propertyMappings = new ArrayList(); Set mappedTargetProperties = new HashSet(); @@ -591,7 +592,7 @@ public class MapperCreationProcessor implements ModelElementProcessor mapperReferences, List methods, - Method method) { + Method method) { Type sourceElementType = method.getSourceParameters().iterator().next().getType().getTypeParameters().get( 0 ); Type targetElementType = method.getResultType().getTypeParameters().get( 0 ); @@ -631,7 +632,7 @@ public class MapperCreationProcessor implements ModelElementProcessor mapperReferences, List methods, - Method method) { + Method method) { List sourceTypeParams = method.getSourceParameters().iterator().next().getType().getTypeParameters(); Type sourceKeyType = sourceTypeParams.get( 0 ); Type sourceValueType = sourceTypeParams.get( 1 ); @@ -689,9 +690,11 @@ public class MapperCreationProcessor implements ModelElementProcessor mapperReferences, - Iterable methods, Type parameterType, - Type returnType) { + Iterable methods, Type parameterType, + Type returnType) { List candidatesWithMathingTargetType = new ArrayList(); for ( Method method : methods ) { diff --git a/processor/src/main/java/org/mapstruct/ap/processor/MethodRetrievalProcessor.java b/processor/src/main/java/org/mapstruct/ap/processor/MethodRetrievalProcessor.java index 139fc1610..49d429398 100644 --- a/processor/src/main/java/org/mapstruct/ap/processor/MethodRetrievalProcessor.java +++ b/processor/src/main/java/org/mapstruct/ap/processor/MethodRetrievalProcessor.java @@ -18,13 +18,10 @@ */ package org.mapstruct.ap.processor; -import static javax.lang.model.util.ElementFilter.methodsIn; - import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; - import javax.annotation.processing.Messager; import javax.lang.model.element.ExecutableElement; import javax.lang.model.element.Modifier; @@ -48,6 +45,8 @@ import org.mapstruct.ap.prism.MappingPrism; import org.mapstruct.ap.prism.MappingsPrism; import org.mapstruct.ap.util.AnnotationProcessingException; +import static javax.lang.model.util.ElementFilter.methodsIn; + /** * A {@link ModelElementProcessor} which retrieves a list of {@link Method}s * representing all the mapping methods of the given bean mapper type as well as diff --git a/processor/src/main/resources/org.mapstruct.ap.model.BeanMappingMethod.ftl b/processor/src/main/resources/org.mapstruct.ap.model.BeanMappingMethod.ftl index 08e60c932..690edf872 100644 --- a/processor/src/main/resources/org.mapstruct.ap.model.BeanMappingMethod.ftl +++ b/processor/src/main/resources/org.mapstruct.ap.model.BeanMappingMethod.ftl @@ -42,4 +42,4 @@ public <@includeModel object=returnType/> ${name}(<#list parameters as param><@i return ${resultName}; -} +} \ No newline at end of file diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Bar.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Bar.java index 8e6bd9dbd..e58f07941 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Bar.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Bar.java @@ -20,14 +20,13 @@ package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod; /** * @author Sjaak Derksen - * */ public class Bar { private String prop; private final String someTypeProp; - public Bar( String someTypeProp ) { + public Bar(String someTypeProp) { this.someTypeProp = someTypeProp; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/FactoryTest.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/FactoryTest.java index d980a9115..503dda360 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/FactoryTest.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/FactoryTest.java @@ -19,7 +19,6 @@ package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod; import org.mapstruct.ap.test.erroneous.ambiguousfactorymethod.a.BarFactory; - import org.mapstruct.ap.testutil.IssueKey; import org.mapstruct.ap.testutil.MapperTestBase; import org.mapstruct.ap.testutil.WithClasses; @@ -30,11 +29,12 @@ import org.testng.annotations.Test; /** * @author Sjaak Derksen - * */ -@IssueKey( "81" ) -@WithClasses( { Bar.class, Foo.class, BarFactory.class, Source.class, SourceTargetMapperAndBarFactory.class, - Target.class } ) +@IssueKey("81") +@WithClasses({ + Bar.class, Foo.class, BarFactory.class, Source.class, SourceTargetMapperAndBarFactory.class, + Target.class +}) public class FactoryTest extends MapperTestBase { @@ -45,12 +45,12 @@ public class FactoryTest extends MapperTestBase { diagnostics = { @Diagnostic(type = BarFactory.class, kind = javax.tools.Diagnostic.Kind.ERROR, - line = 30, - messageRegExp = "^Ambigious factory method: \"org\\.mapstruct\\.ap\\.test\\.erroneous\\." - + "ambiguousfactorymethod\\.Bar createBar\\(\\)\" conflicts with " - + "\"org\\.mapstruct\\.ap\\.test\\.erroneous\\.ambiguousfactorymethod\\.Bar " - + "org\\.mapstruct\\.ap\\.test\\.erroneous\\.ambiguousfactorymethod" - + "\\.a\\.BarFactory\\.createBar\\(\\)\"\\.$") + line = 29, + messageRegExp = "^Ambigious factory methods: \"org\\.mapstruct\\.ap\\.test\\.erroneous\\." + + "ambiguousfactorymethod\\.Bar createBar\\(\\)\" conflicts with " + + "\"org\\.mapstruct\\.ap\\.test\\.erroneous\\.ambiguousfactorymethod\\.Bar " + + "org\\.mapstruct\\.ap\\.test\\.erroneous\\.ambiguousfactorymethod" + + "\\.a\\.BarFactory\\.createBar\\(\\)\"\\.$") } ) public void shouldUseTwoFactoryMethods() { diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Foo.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Foo.java index 700041118..de7b7ef5d 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Foo.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Foo.java @@ -21,7 +21,6 @@ package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod; /** * @author Sjaak Derksen - * */ public class Foo { private String prop; diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Source.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Source.java index 2eb19b681..7cef7446d 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Source.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Source.java @@ -21,7 +21,6 @@ package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod; /** * @author Sjaak Derksen - * */ public class Source { @@ -31,7 +30,7 @@ public class Source { return prop; } - public void setProp( Foo prop ) { + public void setProp(Foo prop) { this.prop = prop; } } diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/SourceTargetMapperAndBarFactory.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/SourceTargetMapperAndBarFactory.java index e707722d6..84e87fed9 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/SourceTargetMapperAndBarFactory.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/SourceTargetMapperAndBarFactory.java @@ -24,18 +24,17 @@ import org.mapstruct.factory.Mappers; /** * @author Sjaak Derksen - * */ -@Mapper( uses = BarFactory.class ) +@Mapper(uses = BarFactory.class) public abstract class SourceTargetMapperAndBarFactory { public static final SourceTargetMapperAndBarFactory INSTANCE = - Mappers.getMapper( SourceTargetMapperAndBarFactory.class ); + Mappers.getMapper( SourceTargetMapperAndBarFactory.class ); public abstract Target sourceToTarget(Source source); public abstract Bar fooToBar(Foo foo); public Bar createBar() { - return new Bar("BAR"); + return new Bar( "BAR" ); } } diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Target.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Target.java index fe8ccd664..04da47e71 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Target.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/Target.java @@ -21,7 +21,6 @@ package org.mapstruct.ap.test.erroneous.ambiguousfactorymethod; /** * @author Sjaak Derksen - * */ public class Target { diff --git a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/a/BarFactory.java b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/a/BarFactory.java index 5a5190a9d..5f72eeb9c 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/a/BarFactory.java +++ b/processor/src/test/java/org/mapstruct/ap/test/erroneous/ambiguousfactorymethod/a/BarFactory.java @@ -22,13 +22,12 @@ import org.mapstruct.ap.test.erroneous.ambiguousfactorymethod.Bar; /** - * * @author Sjaak Derksen */ public class BarFactory { public Bar createBar() { - return new Bar("BAR"); + return new Bar( "BAR" ); } } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/Bar1.java b/processor/src/test/java/org/mapstruct/ap/test/factories/Bar1.java index d477c1ecd..9d4f32a58 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/Bar1.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/Bar1.java @@ -20,14 +20,13 @@ package org.mapstruct.ap.test.factories; /** * @author Sjaak Derksen - * */ public class Bar1 { private String prop; private final String someTypeProp; - public Bar1( String someTypeProp ) { + public Bar1(String someTypeProp) { this.someTypeProp = someTypeProp; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/Bar2.java b/processor/src/test/java/org/mapstruct/ap/test/factories/Bar2.java index 84f5bbecc..9c34ac171 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/Bar2.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/Bar2.java @@ -20,13 +20,12 @@ package org.mapstruct.ap.test.factories; /** * @author Sjaak Derksen - * */ public class Bar2 { private String prop; private final String someTypeProp; - public Bar2( String someTypeProp ) { + public Bar2(String someTypeProp) { this.someTypeProp = someTypeProp; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/Bar3.java b/processor/src/test/java/org/mapstruct/ap/test/factories/Bar3.java index d929ede6c..fd722125d 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/Bar3.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/Bar3.java @@ -20,14 +20,13 @@ package org.mapstruct.ap.test.factories; /** * @author Sjaak Derksen - * */ public class Bar3 { private String prop; private final String someTypeProp; - public Bar3( String someTypeProp ) { + public Bar3(String someTypeProp) { this.someTypeProp = someTypeProp; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/CustomList.java b/processor/src/test/java/org/mapstruct/ap/test/factories/CustomList.java index 3232738d4..1017563d6 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/CustomList.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/CustomList.java @@ -21,7 +21,6 @@ package org.mapstruct.ap.test.factories; import java.util.List; /** - * * @author Sjaak Derksen */ public interface CustomList extends List { diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/CustomListImpl.java b/processor/src/test/java/org/mapstruct/ap/test/factories/CustomListImpl.java index fd9e2cbef..501c1a132 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/CustomListImpl.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/CustomListImpl.java @@ -21,14 +21,13 @@ package org.mapstruct.ap.test.factories; import java.util.LinkedList; /** - * * @author Sjaak Derksen */ public class CustomListImpl extends LinkedList implements CustomList { private final String typeProp; - public CustomListImpl( String typeProp ) { + public CustomListImpl(String typeProp) { this.typeProp = typeProp; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/CustomMap.java b/processor/src/test/java/org/mapstruct/ap/test/factories/CustomMap.java index c825bf623..cf8633204 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/CustomMap.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/CustomMap.java @@ -21,7 +21,6 @@ package org.mapstruct.ap.test.factories; import java.util.Map; /** - * * @author Sjaak Derksen */ public interface CustomMap extends Map { diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/CustomMapImpl.java b/processor/src/test/java/org/mapstruct/ap/test/factories/CustomMapImpl.java index 131121f4b..dabc366b5 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/CustomMapImpl.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/CustomMapImpl.java @@ -21,14 +21,13 @@ package org.mapstruct.ap.test.factories; import java.util.HashMap; /** - * * @author Sjaak Derksen */ public class CustomMapImpl extends HashMap implements CustomMap { private final String typeProp; - public CustomMapImpl( String typeProp ) { + public CustomMapImpl(String typeProp) { this.typeProp = typeProp; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/FactoryTest.java b/processor/src/test/java/org/mapstruct/ap/test/factories/FactoryTest.java index 063a72f61..38c85b61c 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/FactoryTest.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/FactoryTest.java @@ -22,22 +22,24 @@ import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; -import org.mapstruct.ap.test.factories.a.BarFactory; -import static org.fest.assertions.Assertions.assertThat; +import org.mapstruct.ap.test.factories.a.BarFactory; import org.mapstruct.ap.testutil.IssueKey; import org.mapstruct.ap.testutil.MapperTestBase; import org.mapstruct.ap.testutil.WithClasses; import org.testng.annotations.Test; +import static org.fest.assertions.Assertions.assertThat; + /** * @author Sjaak Derksen - * */ -@IssueKey( "81" ) -@WithClasses( { Bar1.class, Foo1.class, Bar2.class, Foo2.class, Bar3.class, Foo3.class, BarFactory.class, +@IssueKey("81") +@WithClasses({ + Bar1.class, Foo1.class, Bar2.class, Foo2.class, Bar3.class, Foo3.class, BarFactory.class, org.mapstruct.ap.test.factories.b.BarFactory.class, Source.class, SourceTargetMapperAndBar2Factory.class, - Target.class, CustomList.class, CustomListImpl.class, CustomMap.class, CustomMapImpl.class } ) + Target.class, CustomList.class, CustomListImpl.class, CustomMap.class, CustomMapImpl.class +}) public class FactoryTest extends MapperTestBase { @Test public void shouldUseTwoFactoryMethods() { @@ -46,19 +48,19 @@ public class FactoryTest extends MapperTestBase { assertThat( target ).isNotNull(); assertThat( target.getProp1() ).isNotNull(); assertThat( target.getProp1().getProp() ).isEqualTo( "foo1" ); - assertThat( target.getProp1().getSomeTypeProp()).isEqualTo( "BAR1" ); + assertThat( target.getProp1().getSomeTypeProp() ).isEqualTo( "BAR1" ); assertThat( target.getProp2() ).isNotNull(); assertThat( target.getProp2().getProp() ).isEqualTo( "foo2" ); - assertThat( target.getProp2().getSomeTypeProp()).isEqualTo( "BAR2" ); + assertThat( target.getProp2().getSomeTypeProp() ).isEqualTo( "BAR2" ); assertThat( target.getProp3() ).isNotNull(); assertThat( target.getProp3().getProp() ).isEqualTo( "foo3" ); - assertThat( target.getProp3().getSomeTypeProp()).isEqualTo( "BAR3" ); + assertThat( target.getProp3().getSomeTypeProp() ).isEqualTo( "BAR3" ); assertThat( target.getPropList() ).isNotNull(); assertThat( target.getPropList().get( 0 ) ).isEqualTo( "fooListEntry" ); - assertThat( target.getPropList().getTypeProp()).isEqualTo( "CUSTOMLIST" ); + assertThat( target.getPropList().getTypeProp() ).isEqualTo( "CUSTOMLIST" ); assertThat( target.getPropMap() ).isNotNull(); assertThat( target.getPropMap().get( "key" ) ).isEqualTo( "fooValue" ); - assertThat( target.getPropMap().getTypeProp()).isEqualTo( "CUSTOMMAP" ); + assertThat( target.getPropMap().getTypeProp() ).isEqualTo( "CUSTOMMAP" ); } private Source createSource() { @@ -81,7 +83,7 @@ public class FactoryTest extends MapperTestBase { source.setPropList( fooList ); Map fooMap = new HashMap(); - fooMap.put( "key", "fooValue"); + fooMap.put( "key", "fooValue" ); source.setPropMap( fooMap ); return source; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/Foo1.java b/processor/src/test/java/org/mapstruct/ap/test/factories/Foo1.java index 723254c66..06b908148 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/Foo1.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/Foo1.java @@ -20,7 +20,6 @@ package org.mapstruct.ap.test.factories; /** * @author Sjaak Derksen - * */ public class Foo1 { private String prop; diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/Foo2.java b/processor/src/test/java/org/mapstruct/ap/test/factories/Foo2.java index 1f607d4c7..5b877b9e7 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/Foo2.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/Foo2.java @@ -20,7 +20,6 @@ package org.mapstruct.ap.test.factories; /** * @author Sjaak Derksen - * */ public class Foo2 { private String prop; diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/Foo3.java b/processor/src/test/java/org/mapstruct/ap/test/factories/Foo3.java index ad9113a65..2b1ef85ae 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/Foo3.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/Foo3.java @@ -20,7 +20,6 @@ package org.mapstruct.ap.test.factories; /** * @author Sjaak Derksen - * */ public class Foo3 { private String prop; diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/Source.java b/processor/src/test/java/org/mapstruct/ap/test/factories/Source.java index 27e94cd74..076a16c13 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/Source.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/Source.java @@ -23,7 +23,6 @@ import java.util.Map; /** * @author Sjaak Derksen - * */ public class Source { @@ -37,7 +36,7 @@ public class Source { return prop1; } - public void setProp1( Foo1 prop1 ) { + public void setProp1(Foo1 prop1) { this.prop1 = prop1; } @@ -45,7 +44,7 @@ public class Source { return prop2; } - public void setProp2( Foo2 prop2 ) { + public void setProp2(Foo2 prop2) { this.prop2 = prop2; } @@ -53,7 +52,7 @@ public class Source { return prop3; } - public void setProp3( Foo3 prop3 ) { + public void setProp3(Foo3 prop3) { this.prop3 = prop3; } @@ -61,7 +60,7 @@ public class Source { return propList; } - public void setPropList( List propList ) { + public void setPropList(List propList) { this.propList = propList; } @@ -69,7 +68,7 @@ public class Source { return propMap; } - public void setPropMap( Map propMap ) { + public void setPropMap(Map propMap) { this.propMap = propMap; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/SourceTargetMapperAndBar2Factory.java b/processor/src/test/java/org/mapstruct/ap/test/factories/SourceTargetMapperAndBar2Factory.java index 1a54bfef0..30bf3a561 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/SourceTargetMapperAndBar2Factory.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/SourceTargetMapperAndBar2Factory.java @@ -20,18 +20,18 @@ package org.mapstruct.ap.test.factories; import java.util.List; import java.util.Map; -import org.mapstruct.ap.test.factories.a.BarFactory; + import org.mapstruct.Mapper; +import org.mapstruct.ap.test.factories.a.BarFactory; import org.mapstruct.factory.Mappers; /** * @author Sjaak Derksen - * */ -@Mapper( uses = { BarFactory.class, org.mapstruct.ap.test.factories.b.BarFactory.class } ) +@Mapper(uses = { BarFactory.class, org.mapstruct.ap.test.factories.b.BarFactory.class }) public abstract class SourceTargetMapperAndBar2Factory { public static final SourceTargetMapperAndBar2Factory INSTANCE = - Mappers.getMapper( SourceTargetMapperAndBar2Factory.class ); + Mappers.getMapper( SourceTargetMapperAndBar2Factory.class ); public abstract Target sourceToTarget(Source source); @@ -46,14 +46,14 @@ public abstract class SourceTargetMapperAndBar2Factory { public abstract CustomMap customMapToMap(Map list); public Bar2 createBar2() { - return new Bar2("BAR2"); + return new Bar2( "BAR2" ); } public CustomList createCustomList() { - return new CustomListImpl("CUSTOMLIST"); + return new CustomListImpl( "CUSTOMLIST" ); } public CustomMap createCustomMap() { - return new CustomMapImpl("CUSTOMMAP"); + return new CustomMapImpl( "CUSTOMMAP" ); } } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/Target.java b/processor/src/test/java/org/mapstruct/ap/test/factories/Target.java index 8ab9696c6..dd833b601 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/Target.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/Target.java @@ -20,7 +20,6 @@ package org.mapstruct.ap.test.factories; /** * @author Sjaak Derksen - * */ public class Target { @@ -42,7 +41,7 @@ public class Target { return prop2; } - public void setProp2( Bar2 prop2 ) { + public void setProp2(Bar2 prop2) { this.prop2 = prop2; } @@ -50,7 +49,7 @@ public class Target { return prop3; } - public void setProp3( Bar3 prop3 ) { + public void setProp3(Bar3 prop3) { this.prop3 = prop3; } @@ -58,7 +57,7 @@ public class Target { return propList; } - public void setPropList( CustomList propList ) { + public void setPropList(CustomList propList) { this.propList = propList; } @@ -66,7 +65,7 @@ public class Target { return propMap; } - public void setPropMap( CustomMap propMap ) { + public void setPropMap(CustomMap propMap) { this.propMap = propMap; } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/a/BarFactory.java b/processor/src/test/java/org/mapstruct/ap/test/factories/a/BarFactory.java index 67590242d..34ef75771 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/a/BarFactory.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/a/BarFactory.java @@ -21,13 +21,12 @@ package org.mapstruct.ap.test.factories.a; import org.mapstruct.ap.test.factories.Bar1; /** - * * @author Sjaak Derksen */ public class BarFactory { public Bar1 createBar1() { - return new Bar1("BAR1"); + return new Bar1( "BAR1" ); } } diff --git a/processor/src/test/java/org/mapstruct/ap/test/factories/b/BarFactory.java b/processor/src/test/java/org/mapstruct/ap/test/factories/b/BarFactory.java index c1af01d95..f130f731e 100644 --- a/processor/src/test/java/org/mapstruct/ap/test/factories/b/BarFactory.java +++ b/processor/src/test/java/org/mapstruct/ap/test/factories/b/BarFactory.java @@ -21,13 +21,12 @@ package org.mapstruct.ap.test.factories.b; import org.mapstruct.ap.test.factories.Bar3; /** - * * @author Sjaak Derksen */ public class BarFactory { public Bar3 createBar3() { - return new Bar3("BAR3"); + return new Bar3( "BAR3" ); } }