third_codes/oauth2
1
0
Fork 0
mirror of https://github.com/golang/oauth2.git synced 2025-07-21 00:00:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

oauth2: clarify comment about tokenRefresher's thread safety

Browse Source 
Change-Id: I9a3faedb8faf7701be7c82c7fff964b56d7c96c8
Reviewed-on: https://go-review.googlesource.com/4116
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Andrew Gerrand 2015-02-07 21:27:57 +00:00
parent cc2494a288
commit 1406aeefb0
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
oauth2.go
View File

@ -250,6 +250,10 @@ type tokenRefresher struct {
refreshToken string refreshToken string
} }
// WARNING: Token is not safe for concurrent access, as it
// updates the tokenRefresher's refreshToken field.
// Within this package, it is used by reuseTokenSource which
// synchronizes calls to this method with its own mutex.
func (tf *tokenRefresher) Token() (*Token, error) { func (tf *tokenRefresher) Token() (*Token, error) {
if tf.refreshToken == "" { if tf.refreshToken == "" {
return nil, errors.New("oauth2: token expired and refresh token is not set") return nil, errors.New("oauth2: token expired and refresh token is not set")
@ -263,9 +267,7 @@ func (tf *tokenRefresher) Token() (*Token, error) {
if err != nil { if err != nil {
return nil, err return nil, err
} }
if tk.RefreshToken != tf.refreshToken { if tf.refreshToken != tk.RefreshToken {
// possible race condition avoided because tokenRefresher
// should be protected by reuseTokenSource.mu
tf.refreshToken = tk.RefreshToken tf.refreshToken = tk.RefreshToken
} }
return tk, err return tk, err