From 5a0a1b2881223fc8dab48f661e7a4d808c1242fb Mon Sep 17 00:00:00 2001 From: HuKeping Date: Thu, 5 Mar 2015 19:30:40 +0800 Subject: [PATCH] oauth2: remove unnecessary ClientSecret check Since the empty client secret is permitted by the OAuth 2.0 spec. The check for clientSecret in retriveTokoen is unnecessary. Redo #6740 Signed-off-by: Hu Keping Change-Id: I9126c79a1f8b9d6051c213ee3f93c442a36ca65d Reviewed-on: https://go-review.googlesource.com/6900 Reviewed-by: Andrew Gerrand --- oauth2.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/oauth2.go b/oauth2.go index 26828b9..21d2730 100644 --- a/oauth2.go +++ b/oauth2.go @@ -308,7 +308,7 @@ func retrieveToken(ctx context.Context, c *Config, v url.Values) (*Token, error) return nil, err } req.Header.Set("Content-Type", "application/x-www-form-urlencoded") - if !bustedAuth && c.ClientSecret != "" { + if !bustedAuth { req.SetBasicAuth(c.ClientID, c.ClientSecret) } r, err := hc.Do(req)