From cf1431934151b3a93e0b3286eb6798ca08ea3770 Mon Sep 17 00:00:00 2001 From: Christopher Taylor Date: Thu, 21 Nov 2024 13:21:11 +0100 Subject: [PATCH] oauth2: fix expiration time window check Before CL 68017, the test verified that tokens expire exactly one day after they are issued, within the time that Exchange() takes to execute. A refactoring in the CL extended this time window to a whole day, making the check much more lenient. See: https://go-review.googlesource.com/c/oauth2/+/168017 Change-Id: I479db429f64b25a711624817c13f068b4675163e Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/630495 LUCI-TryBot-Result: Go LUCI Reviewed-by: Junyang Shao Reviewed-by: Sean Liao Auto-Submit: Sean Liao Reviewed-by: Carlos Amedee --- oauth2_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/oauth2_test.go b/oauth2_test.go index 1cc14c6..5db78f2 100644 --- a/oauth2_test.go +++ b/oauth2_test.go @@ -300,7 +300,7 @@ func testExchangeRequest_JSONResponse_expiry(t *testing.T, exp string, want, nul conf := newConf(ts.URL) t1 := time.Now().Add(day) tok, err := conf.Exchange(context.Background(), "exchange-code") - t2 := t1.Add(day) + t2 := time.Now().Add(day) if got := (err == nil); got != want { if want {